Standup Notes 2020 02 12

Participants (alphabetical): Allie, Conor, Erik, Jen, John, Kevin, Kushal, Mickael, Ro

Topics and Call-outs

• Whonix team member Patrick Schleizer asking for upstream coordination: https://github.com/freedomofpress/securedrop-workstation/issues/451 - Jen'll respond after this

• Reminder: Feature freeze for SecureDrop 1.2.1 EOD today

• Next steps on #5109 / #5110

  • Current PR causes problems regressing us to pip, setuptools, wheel versions that are too old

Allie

Yesterday:

• Didn't get to cupsenable bug fixin
• Reviewed John's source fingerprint PR, fixes issue, needs rebase
• Reviewed Nick's last-sync-time PR
• Reviewed Nick's source-deletion PR
• Ran into a reply-ordering bug and worked on a reliable STR report: https://github.com/freedomofpress/securedrop-client/issues/653
• Updated architecture documents per refactor doc: https://github.com/freedomofpress/securedrop-client/wiki/Architecture#sync-architecture
• Responded to review comments on my queue refactor PR

Today:

• Discuss reply-ordering bug as needed
• Re-review last-sync-time PR as needed
• Re-review John's source fingerprint PR as needed
• Review https://github.com/freedomofpress/securedrop-client/pull/789
• Review https://github.com/freedomofpress/securedrop-client/pull/792
• If there's time, work on a fix for cupsenable bug

Blockers or Asks:

Conor

Yesterday:

• reviewed & merged new dev config pkgs https://github.com/freedomofpress/securedrop-dev-packages-lfs/pull/34
• reviewed https://github.com/freedomofpress/securedrop-workstation/pull/450

Today:

• review draft PR for prod lfs packages by mickael
• review https://github.com/freedomofpress/securedrop-workstation/pull/445 (visual review fine, mickael already reviewed)

Blockers or Asks:

• suggest check-in of priority for https://github.com/freedomofpress/securedrop/pull/5110 ; recommend defer to past point release/pilot-launch

Erik

Yesterday:

• Got #445 (sdw-notify) to 100% test coverage, notified in case of "no timestamp/bad data" cases, more refactoring
• Priorities check-in w/ Nina; focusing on update/notify-related UX & SecureDrop core follow-up (Tor browser changes) rn

Today:

• Re-test and run black formatter on #445
• Work on network troubleshooting docs

Blockers or Asks: None

Jen

Yesterday:

• bunch of testing of queue pause/resume - found a couple issues which we can discuss during UX (replies resuming being the one i flagged in securedrop-workstation, there's also the fact that the queues pause independently)
• i did end up figuring out the CI issues on master in SDK, which got merged thanks!

Today:

• given the above now am unblocked to release securedrop-sdk 0.0.13 today (will merge kushal's PR)

Blockers or Asks:

• none

John

Yesterday:

• Started on reviews, got derailed by Qubes SD staging setup

Today:

• 1.2.1 release tasks

Blockers or Asks:

• Will be leaning heavily on Kev/Jen

Kev

Yesterday:

• Worked a bit more on build pinning issue

Today:

• Support-related issues
• Updating PR to address "updater has just run" case
• Deputy RM responsibilities for 1.2.1

Blockers or Asks: None

Kushal

Today:

• Added tests and marked https://github.com/freedomofpress/securedrop-workstation/pull/447 as ready for review
• Reviewed and merged https://github.com/freedomofpress/securedrop-sdk/pull/112
• Created the release + changelog PR for new SDK release https://github.com/freedomofpress/securedrop-sdk/pull/113
• Reviewed and approved https://github.com/freedomofpress/securedrop-client/pull/793
• Reviewed https://github.com/freedomofpress/securedrop-client/pull/786 but forgot to comment on the ticket :( Tomorrow:

• based on feedback Blockers or Asks: None

Mickael

Yesterday:

• Prod workstation kernel packages / repo metadata https://github.com/freedomofpress/securedrop-debian-packages-lfs/pull/9
• opened pr for running black for launcher code https://github.com/freedomofpress/securedrop-workstation/pull/452
• second review of uptime notification https://github.com/freedomofpress/securedrop-workstation/pull/445 Today:
• Review https://github.com/freedomofpress/securedrop-workstation/pull/447/files (logging)
• Final pass on uptime notifications

Blockers or Asks: None

Nicholas

Today:

• Fixed up PR #790 as per Allie's refactoring requests.
• Continued work on functional tests. Making slow but steady progress (programatically setting up the app for isolated / repeatable functional testing, vcr setup etc...). I hope to have something to show for it all tomorrow.

• Blockers / Asks:*
  • None

Ro

Yesterday:

• SD Meetings
• bit of time on workstation docs
• misc support comms

Today:

• moderately interesting support issue (thanks Kev!): https://github.com/freedomofpress/securedrop/issues/5120
• more SD meetings and followup
• finalize upcoming travel, travel approval for upcoming DST engagement (blocking on H's schedule)
• workstation docs: glossary

Blockers or Asks: None