-
Notifications
You must be signed in to change notification settings - Fork 685
Standup Notes 2020 01 30
Participants (alphabetical): Allie, Conor, Erik, Jen, John, Kevin, Kushal (async), Mickael, Ro
- Workstation USB autoattach has been merged! Clone latest master in dom0 and run make add-usb-autoattach (assuming workstation built after vm rename)
- Moment to discuss "staging" of dom0 RPMs (in particular with Jen, Mickael, Conor) -Conor
(PR review & follow-up)
Yesterday:
- AFK at conference (Usenix Enigma)
Today:
- Review of https://github.com/freedomofpress/securedrop-workstation-dev-rpm-packages-lfs/pull/4
- Review/collab https://github.com/freedomofpress/securedrop-workstation/pull/432
Blockers or Asks: None
Yesterday:
- Reviewed open networking issues w/ Allie & moved networking test plan here: https://github.com/freedomofpress/securedrop-client/wiki/Test-plan
- more granular than ultimately needed, right now we have a lot of churn and need to make sure we avoid regressions across the board
- A bit more review on journalist guide changes
- SD support work
- Updated export format specs to match current reality
- A bit more research into locking strategies for ensuring updater & notifier scripts don't clash
Today:
- Issues work in the AM
- Focus time on docs in the PM
- Then, if time allows, cont'd work on notifier script ( https://github.com/freedomofpress/securedrop-workstation/pull/389 )
Blockers or Asks: None
Yesterday:
- At conf
Today:
- Look at file handling logic that Allie and John have been working on
- https://github.com/freedomofpress/securedrop-client/pull/750
- Also gonna look at the staging rpm strategy in workstation
- PM: Working with Conor
- Heads up tomorrow will be traveling, but back as usual on Monday. Gonna move some of my meetings to Monday, hope that's OK with folks.
Blockers or Asks:
- None
Yesterday:
- reviewed/merged two syslog PRs
- finished cleanup logic in auto-attach PR
- merged https://github.com/freedomofpress/securedrop-client/pull/744
- discussed client download handling
- reviewed https://github.com/freedomofpress/securedrop-client/pull/724
Today:
- #724
- https://github.com/freedomofpress/securedrop-workstation/pull/418
- hopefully finish client download handling
Blockers or Asks:
- Jen, if you have time to catch up on the client download discussion...
- I do! will check it out
Yesterday:
- Investigate core #5110
- Review Ro's docs PR
Today:
- ^ Cont'd on #5110
- Cont'd docs review
Blockers or Asks:
Today:
- Reviewed and merged https://github.com/freedomofpress/securedrop-client/pull/722
- Reviewed https://github.com/freedomofpress/securedrop-client/pull/750 , this needs more work
- Reviewed and merged https://github.com/freedomofpress/securedrop-client/pull/748
- Reviewed https://github.com/freedomofpress/securedrop-workstation/pull/436 will re-review tomorrow and merge
Tomorrow:
- more reviews Blockers or Asks:
- None
Yesterday:
- Reviewed/merged https://github.com/freedomofpress/securedrop-workstation/pull/324 (usb autoattach)
- Reviewed/requested changes on https://github.com/freedomofpress/securedrop-log/pull/8/files (syslog PR, some packaging changes will likely be required)
- Reviewed/merged https://github.com/freedomofpress/securedrop-workstation/pull/433 (flag file rename + cleanup)
- Opened https://github.com/freedomofpress/securedrop-workstation/pull/436 (fixed edge case for reboot logic)
- Reviewed https://github.com/freedomofpress/securedrop-export/pull/54 Today:
- meetings
- release management, perhaps template rebuild?
- more work on https://github.com/freedomofpress/securedrop-workstation/pull/432 , if required Blockers or Asks:
- conor (or other) comments on approach in https://github.com/freedomofpress/securedrop-workstation/pull/432 (note, staging scenario should only be run on test-only hardware). Should we re-consider the staging environment here?
-
Today: *
-
Continued work on #707. This involved:
-
Figuring out SqlAlchemy related Gremlins (apparently sessions get "stale" and require a commit to ensure newly downloaded data is available)
-
Working around said gremlins (handling the new items in such a way that their content becomes available)
-
Creating PR #752 (draft) so folks can see this approach along with associated unit tests
-
Performance testing (200 sources) which raised the dreaded unresponsive UI problem again
-
Making inroads to address the performance problems. I'm confident I understand the problem and should be able to apply a fix on Monday. Currently every new message gets handled by every source widget. What we need is every new message to be handled once by exactly the right single source. This will require re-jigging how things are connected via signals/slots.
-
-
-
Blockers or Asks: *
- None, but feel free to take a look at PR # 752. I welcome comments.
- Tomorrow (Friday) isn't an FPF day for me. I'll be online if you need me, but will be working on other things.
Yesterday:
- Support comms & many meetings
- Improved invoice/quote tracking plan with Ryan
- IVF/directory listing update
- Low-key Qubes + LUKS drive unmounting/remounting issue that, if I can successfully isolate/repro, I may file an upstream issue for (or there may be one already)
Today:
- last few changes from docs PR (ready for review) https://github.com/freedomofpress/securedrop-workstation-docs/pull/13
- ro vs enigmail
- Pinging a few instances re older config or landing page issues; following up on some comms from yesterday
Blockers or Asks:
- Ask: I've been filing some issues as I run into things on the workstation; if I file issues in the wrong spot (client vs workstation), or if I can improve the quality of my issues, don't be shy to let me know.