The Sharing Tab

[keithharvey]

📚 Reviewed via the file-partitioned split — bottom-up

• 1/7 · Transfer library (enums, comms, serialization, test infra) (sharing 1/7: Transfer library (enums, comms, serialization, test infra) #8125)
• 2/7 · Modes & economy boundary (presets, waterfill, share ledger) (sharing 2/7: Modes & economy boundary (presets, waterfill, share ledger) #8126)
• 3/7 · Policies (context -> policy -> policy_result -> action) (sharing 3/7: Policies (context → policy → policy_result → action) #8123)
• 4/7 · Transfer runtime (controllers, economy boundary, gadget swap) (sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap) #8062)
• 5/7 · Tech Core / Keystone (sharing 5/7: Tech Core / Keystone #8063)
• 6/7 · Sharing Tab UI (sharing 6/7: Sharing Tab UI #8064)
• 7/7 · Game modes export (export widget, headless startscript, CI workflow) (sharing 7/7: Game modes export (widget, headless startscript, CI workflow) #8095)

Important

This PR is the merge vehicle for the whole feature — review happens in the split PRs above. Its tree is byte-identical to the assembled split tip. Merge order: the type-migration stack (#8235) lands first; then this PR's base flips to master (the diff doesn't change — the stack is already built on the migrated base) and it merges through the GitHub UI. The split PRs are closed afterwards; their content is contained here.

Each PR is file-partitioned: every file appears in exactly one PR in its final sharing_tab form, so each PR's diff is byte-identical to that branch. Regenerated deterministically by just bar::sharing-split.

[keithharvey]

I'm going to move this one back to draft because in a downstream branch I moved all of this to lua and simplified some things to make testing sharing_modes easier. Will backport isolated bits of that PR if it fails to merge. That approach has some downsides (like a lack of a schema validation in the CI), but those are compensated for with types and specs.

[github-actions]

Test Results

20 tests  +4   10 ✅ +3   17s ⏱️ +14s
 1 suites ±0    9 💤 ±0 
 1 files   ±0    1 ❌ +1 

For more details on these failures, see this check.

Results for commit ce774d4. ± Comparison against base commit cf64f44.

♻️ This comment has been updated with latest results.

[github-actions]

Integration Test Results

18 tests  +4   6 ✅ ±0   3s ⏱️ ±0s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   4 ❌ +4 

For more details on these failures, see this check.

Results for commit 4fbdd6f. ± Comparison against base commit 1a0bec9.

♻️ This comment has been updated with latest results.

[Jinxer128]

Taking is not supported, regardless of whether sharing is enabled or not.
Sending resources doesn't cost any resources, both when taxes are on or off.
Sharing slider bar doesn't continually update with the teammate's available storage.

[keithharvey]

@Jinxer128 should be sorted. Tried an ambitious refactor and it didn't work out. Went back to the known-working solution.

[Jaedrik]

bugs

☑️ When using other sharing modes (not the default Enabled), Transfer units requires very inconsistent amounts of clicks on the ui (rather than double click as the UI indicates). Sometimes, there's a transfer delay even after successful double click.
☑️ Transfer units chat message has the wrong color of the target teammate.
☑️ When Tech Core is enabled, box select doesn't discriminate between constructors and fighting units like the base game does and instead grabs all of them.

ts fixed good jqob 👍

[keithharvey]

To test SPADS locally, from BAR-Devtools, check out the fix_wsl branch and run:

just chobby::dev-mode on
just chobby::server local
just spads::export-modes
just services::up

just bar::launch

# get a regular user to login with the default password to join the lobby so votes trigger
just tei::add-user bob
just tei::join-battle bob

The repos.local.conf to test this from BAR-Devtools:

cat > repos.local.conf <<'EOF'
@local_root ~/code

bar_debug_launcher  https://github.com/keithharvey/bar_debug_launcher.git cli
RecoilEngine        https://github.com/keithharvey/RecoilEngine.git resource-excess-callin-stats
BYAR-Chobby         https://github.com/keithharvey/BYAR-Chobby.git sharing_tab
Beyond-All-Reason   https://github.com/keithharvey/bar.git sharing_tab
EOF