T2 Constructor Sharing Mode

[keithharvey]

Closes #4416

LLM Usage

A bit on this one. Gemini iirc. This was one of my first times using LLMs for coding and it ended up being mostly by hand because it honestly wasn't super helpful.

Refactor: T2 Constructor Sharing and Fix Take Command

This PR refactors unit sharing logic, introduces the requested "T2 Constructor Sharing Only" mode, and fixes related bugs with the /take command and Unit Market interactions.

Problem Description & Motivation

• Implement t2cons Sharing Mode: Provide the community-requested middle ground sharing option (Disabled Unit Sharing Except T2 #4416) between fully enabled and fully disabled, reflecting the common meta of sharing T2 constructors in team games.
• Fix /take Command Bug: Resolve the issue where restricted sharing modes (disabled or t2cons) incorrectly blocked the /take command, preventing players from taking control of inactive allied teams.
• Decouple Unit Market: Address feedback from previous reviews that unit sharing logic was improperly intertwined with Unit Market functionality. The goal is to allow the Unit Market to operate independently.

Implementation Approach & Changes

Unit Sharing Mode (luarules/gadgets/game_unit_sharing_mode.lua):
* Renamed game_disable_unit_sharing.lua to game_unit_sharing_mode.lua for clarity and naming convention.
* Converted the "Disable Unit Sharing" checkbox into a unit_sharing_mode dropdown option with keys: enabled (default), t2cons, combat, combat_t2cons, disabled. (Renamed t2cons_only to t2cons for brevity).
* Refactored AllowUnitTransfer to correctly check the selected mode for standard player-to-player transfers.
* Unit Market Decoupling: Implemented a flag (marketTransferInProgress). game_unit_market.lua sets this flag before transfer; game_unit_sharing_mode.lua checks and clears it, bypassing sharing rules for market transactions.
* /take Command Fix: Added a workaround function (CheckTakeCondition) that bypasses sharing rules if the sender is allied and has no active human players, mirroring the engine's apparent condition for /take. This was necessary as /take doesn't set capture=true or provide another detectable flag. (Includes a TODO and suggestion for a future engine flag improvement).
* Preserved the capture=true check to allow engine-managed transfers.

Testing Results

• Verified unit_sharing_mode options:
  • enabled: Allows all standard transfers.
  • t2cons: Allows standard transfer of T2 constructors (e.g., armack), blocks T1 constructors, factories, combat units.
  • disabled: Blocks all standard transfers.
• Verified bypasses work correctly when sharing is restricted (disabled or t2cons):
  • Unit Market purchases/sales succeed.
  • /take <TeamID> command successfully transfers all units from inactive allied teams.
  • Engine-managed transfers (capture=true) succeed.

Release Notes

• The disable_unit_sharing checkbox mod option has been replaced by the unit_sharing_mode dropdown list option.
  • Old !bset modoption disable_unit_sharing 1 is now !bset modoption unit_sharing_mode disabled.
  • Old !bset modoption disable_unit_sharing 0 is now !bset modoption unit_sharing_mode enabled.
  • The new option is !bset modoption unit_sharing_mode t2cons.
• This should probably be published with the new Metal Send Threshold feature, since this enables standard transfers of t2 cons/payment mechanisms, while still allowing taxes to be in place, which is pretty important for this feature.

Before

After

(ignore the overlap in the screenshot I fixed that at some point)

[keithharvey]

@WatchTheFort cleaned this up and it's now ready for you to review

[keithharvey]

Thank you @badosu for all of your help!

[badosu]

Overall LGTM, some small things to address, up to the author but in general looks solid!

[keithharvey]

Moving into widgets necessitated a common set of helper functions, which is all good.

At minimum the "Share Unit" button should be removed from the commands panel when no t2 cons are selected

This is hard. Like why won't it redraw? I tried to make it dynamic then I tried to separate commands, neither redrew on selection. Not sure whatsup with that but Imma give up and work on something else.

and there should be an echo explaining the blocking of sharing

This one is done

@thehobojoe feel free to integrate this into another PR or merge this one. I think maybe we change the PR target of this and metal_send_threshold and emp to a new branch you create tonight (combined_mod_options?) that we can then rebase on top of with some of this other chobby/organizational work. I rebased this one too and I think both are ready to roll.

[thehobojoe]

This is hard. Like why won't it redraw? I tried to make it dynamic then I tried to separate commands, neither redrew on selection. Not sure whatsup with that but Imma give up and work on something else.

Redraw already happens on every selection change. You can see how to accomplish this here

[keithharvey]

This is hard. Like why won't it redraw? I tried to make it dynamic then I tried to separate commands, neither redrew on selection. Not sure whatsup with that but Imma give up and work on something else.

Redraw already happens on every selection change. You can see how to accomplish this here

Interestingly I was already doing that, let me test this again.

edit: On testing, the branch linked also always shows the transfer button I was attempting to fix. I thought we were talking about this button in advanced player list:

[keithharvey]

Ok that's done, the share button in adv playerlist now shows a greyed out transfer button [with a tooltip I failed to screen grab that reads "Attempted to transfer 1 unshareable units. Share mode is T2 constructors only"

[keithharvey]

This commit was lost to time and very valuable: f60bdfc#diff-40c052408aba0b8d61ccb4d5dbd6743bc00d82a1dc532342290f5c0587c7f8c8

Putting this here so I don't have to rummage again, accidentally force pushed this branch to an old as hell version at some point, and am probably going to just put this feature on top of metal_send_threshold, since they are all up in gui_advplayerslist business in the same places.

[keithharvey]

This branch is now at the exact same place as player send threshold, since they share a lot of common code and I think these go together if they go. I can close this one or keep it open for the description.

[keithharvey]

Closing this in favor of player_send_threshold or possibly some different PR. Really both of these PRs together are the "split mod option" approach to team sharing and should be a unified PR.

I'm tired of maintaining it in isolation/it's REALLY hard to keep these two branches separated in gui_advplayerlist, though I did try at the commit level.