Skip to content

sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap)#8062

Draft
keithharvey wants to merge 1 commit into
sharing_policy_corefrom
sharing/02-transfer-runtime
Draft

sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap)#8062
keithharvey wants to merge 1 commit into
sharing_policy_corefrom
sharing/02-transfer-runtime

Conversation

@keithharvey

@keithharvey keithharvey commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

📚 Stacked split of #5704 — review bottom-up

Each PR is file-partitioned: every file appears in exactly one PR in its final sharing_tab form, so each PR's diff is byte-identical to that branch. Regenerated deterministically by just bar::sharing-split.

Summary (LLM-generated, claude-opus-4-6)

Adds the two runtime controllers — game_resource_transfer_controller (Lua-owned overflow redistribution via WaterfillSolver on the new ResourceExcess callin, plus the GG.* economy boundary that all gadgets now call through) and game_unit_transfer_controller (policy-driven AllowUnitTransfer / TeamShare with stun and build-delay penalties read from PolicyResult). Replaces six legacy gadgets (game_no_share_to_enemy, game_prevent_excessive_share, game_disable_unit_sharing, game_restrict_unit_sharing, game_tax_resource_sharing, game_restrict_resurrection) with mode-enum-driven equivalents (game_allied_unit_reclaim_mode, game_allow_partial_resurrection, game_disable_ally_geo_mex_upgrades, game_share_policy_forwarding), renames game_disable_assist_allygame_allied_assist_mode, and migrates every synced caller from direct Spring.GetTeamResources / Spring.AddTeamResource / Spring.ShareTeamResource to the GG.* economy boundary. Introduces cmd_take as a standalone /take gadget supporting TakeMode.Enabled, StunDelay, and TakeDelay, adds ShareStats for Lua-side sent/received tracking via team rules params, and sets nativeExcessSharing = false / allowTake = false unconditionally in modrules.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

17 tests  +3   6 ✅ ±0   6s ⏱️ +3s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   3 ❌ +3 

For more details on these failures, see this check.

Results for commit 7e7c599. ± Comparison against base commit 4945e13.

♻️ This comment has been updated with latest results.

@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 1f5b919 to aff6801 Compare June 22, 2026 19:05
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 1d313d0 to e40bb94 Compare June 24, 2026 07:58
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from aff6801 to 9178a16 Compare June 24, 2026 07:58
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from e40bb94 to d2097ec Compare June 25, 2026 21:37
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 9178a16 to 5dd928e Compare June 25, 2026 21:37
@keithharvey keithharvey changed the title sharing 2/4: transfer runtime (controllers, economy boundary, gadget swap) sharing 2/5: transfer runtime (controllers, economy boundary, gadget swap) Jun 25, 2026
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from d2097ec to 959aac8 Compare June 25, 2026 22:26
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 5dd928e to 87d566f Compare June 25, 2026 22:26
@keithharvey keithharvey changed the title sharing 2/5: transfer runtime (controllers, economy boundary, gadget swap) sharing 3/6: transfer runtime (controllers, economy boundary, gadget swap) Jun 28, 2026
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 959aac8 to ba33b5f Compare June 28, 2026 06:51
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch 3 times, most recently from c9367a4 to 6c0e5d8 Compare June 28, 2026 07:28
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 9d6f82e to 4ad5fe3 Compare June 28, 2026 07:28
@keithharvey keithharvey changed the base branch from sharing/01-foundations to sharing/modes-economy June 28, 2026 07:28
@keithharvey keithharvey changed the title sharing 3/6: transfer runtime (controllers, economy boundary, gadget swap) sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap) Jun 28, 2026
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 6c0e5d8 to 7504241 Compare June 28, 2026 09:02
@keithharvey keithharvey force-pushed the sharing/modes-economy branch from 84cfbd0 to 2fb534e Compare June 28, 2026 09:02
Base automatically changed from sharing/modes-economy to sharing_policy_core June 28, 2026 09:02
@keithharvey keithharvey force-pushed the sharing_policy_core branch from 7e9b0a6 to ea79738 Compare June 30, 2026 00:38
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 7504241 to 304be0f Compare June 30, 2026 00:38
@keithharvey keithharvey force-pushed the sharing_policy_core branch from ea79738 to e15b226 Compare June 30, 2026 01:30
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 304be0f to 585e697 Compare June 30, 2026 01:30
@keithharvey keithharvey force-pushed the sharing_policy_core branch from e15b226 to eabd59c Compare June 30, 2026 03:11
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 585e697 to 7ed7b30 Compare June 30, 2026 03:12
@keithharvey keithharvey force-pushed the sharing_policy_core branch from eabd59c to 825375d Compare June 30, 2026 04:42
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 7ed7b30 to ef70d7b Compare June 30, 2026 04:42
@keithharvey keithharvey marked this pull request as draft June 30, 2026 05:38
@keithharvey keithharvey force-pushed the sharing_policy_core branch from 825375d to 915d61b Compare June 30, 2026 07:06
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from ef70d7b to 0272d09 Compare June 30, 2026 07:06
@keithharvey keithharvey force-pushed the sharing_policy_core branch from 915d61b to 8ac356f Compare June 30, 2026 08:16
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 0272d09 to 8a2c779 Compare June 30, 2026 08:17
@keithharvey keithharvey force-pushed the sharing_policy_core branch from 8ac356f to 9bf4314 Compare July 1, 2026 20:31
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 8a2c779 to 30dca89 Compare July 1, 2026 20:32
@keithharvey keithharvey force-pushed the sharing_policy_core branch from 9bf4314 to 4945e13 Compare July 1, 2026 20:47
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 30dca89 to 7e7c599 Compare July 1, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant