sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap)#8062
Draft
keithharvey wants to merge 1 commit into
Draft
sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap)#8062keithharvey wants to merge 1 commit into
keithharvey wants to merge 1 commit into
Conversation
Contributor
Integration Test Results17 tests +3 6 ✅ ±0 6s ⏱️ +3s For more details on these failures, see this check. Results for commit 7e7c599. ± Comparison against base commit 4945e13. ♻️ This comment has been updated with latest results. |
This was referenced Jun 22, 2026
Draft
1f5b919 to
aff6801
Compare
1d313d0 to
e40bb94
Compare
aff6801 to
9178a16
Compare
e40bb94 to
d2097ec
Compare
9178a16 to
5dd928e
Compare
d2097ec to
959aac8
Compare
5dd928e to
87d566f
Compare
This was referenced Jun 25, 2026
959aac8 to
ba33b5f
Compare
c9367a4 to
6c0e5d8
Compare
9d6f82e to
4ad5fe3
Compare
6c0e5d8 to
7504241
Compare
84cfbd0 to
2fb534e
Compare
This was referenced Jun 28, 2026
7e9b0a6 to
ea79738
Compare
7504241 to
304be0f
Compare
ea79738 to
e15b226
Compare
304be0f to
585e697
Compare
e15b226 to
eabd59c
Compare
585e697 to
7ed7b30
Compare
eabd59c to
825375d
Compare
7ed7b30 to
ef70d7b
Compare
825375d to
915d61b
Compare
ef70d7b to
0272d09
Compare
915d61b to
8ac356f
Compare
0272d09 to
8a2c779
Compare
8ac356f to
9bf4314
Compare
8a2c779 to
30dca89
Compare
9bf4314 to
4945e13
Compare
30dca89 to
7e7c599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked split of #5704 — review bottom-up
Each PR is file-partitioned: every file appears in exactly one PR in its final
sharing_tabform, so each PR's diff is byte-identical to that branch. Regenerated deterministically byjust bar::sharing-split.Summary (LLM-generated, claude-opus-4-6)
Adds the two runtime controllers —
game_resource_transfer_controller(Lua-owned overflow redistribution viaWaterfillSolveron the newResourceExcesscallin, plus theGG.*economy boundary that all gadgets now call through) andgame_unit_transfer_controller(policy-drivenAllowUnitTransfer/TeamSharewith stun and build-delay penalties read fromPolicyResult). Replaces six legacy gadgets (game_no_share_to_enemy,game_prevent_excessive_share,game_disable_unit_sharing,game_restrict_unit_sharing,game_tax_resource_sharing,game_restrict_resurrection) with mode-enum-driven equivalents (game_allied_unit_reclaim_mode,game_allow_partial_resurrection,game_disable_ally_geo_mex_upgrades,game_share_policy_forwarding), renamesgame_disable_assist_ally→game_allied_assist_mode, and migrates every synced caller from directSpring.GetTeamResources/Spring.AddTeamResource/Spring.ShareTeamResourceto theGG.*economy boundary. Introducescmd_takeas a standalone/takegadget supportingTakeMode.Enabled,StunDelay, andTakeDelay, addsShareStatsfor Lua-side sent/received tracking via team rules params, and setsnativeExcessSharing = false/allowTake = falseunconditionally in modrules.