Add T-compiler backports Zulip notifications #140397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
|
|
fmease
reviewed
Apr 28, 2025
There was a problem hiding this comment.
I know this isn't strictly related but could you remove those four FIXMEs attached to the T-rustdoc+{stable,beta}-{nominated,accepted} handlers now that they've been fixed by rust-lang/triagebot#1853?
Otherwise you or I can send a separate PR. Edit: Eh, let's do that.
apiraino
force-pushed
the
t-compiler-backports-zulip-notifications
branch
from
170a129 to
b5e9db1
Compare
jieyouxu
reviewed
Apr 28, 2025
jieyouxu
added
the
T-compiler
apiraino
force-pushed
the
t-compiler-backports-zulip-notifications
branch
from
b5e9db1 to
3f4e535
Compare
fmease
reviewed
May 3, 2025
davidtwco
approved these changes
May 7, 2025
|
@bors r=davidtwco rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2025
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#140397 (Add T-compiler backports Zulip notifications) - rust-lang#140851 (Warn when `#[export_name]` is used with generic functions) - rust-lang#140862 (Enable non-leaf Frame Pointers for Arm64EC Windows) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2025
Rollup merge of rust-lang#140397 - apiraino:t-compiler-backports-zulip-notifications, r=davidtwco Add T-compiler backports Zulip notifications This patch make it so, that the triagebot willl send notifications to the Zulip channel [#t-compiler/backports](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports) when a label `{stable-beta}-nominated` is added to beta or stable backport pull request. Requirement to trigger this notification is that the pull request be labeled `T-compiler`. Note: Zulip notifications can send notifications also on other events (`message_on_close` and `message_on_reopen`) but I omitted them for now, I am not yet sure we need them. r? `@davidtwco`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch make it so, that the triagebot willl send notifications to the Zulip channel #t-compiler/backports when a label
{stable-beta}-nominatedis added to beta or stable backport pull request. Requirement to trigger this notification is that the pull request be labeledT-compiler.Note: Zulip notifications can send notifications also on other events (
message_on_closeandmessage_on_reopen) but I omitted them for now, I am not yet sure we need them.r? @davidtwco