Skip to content

Use new form for T-rustdoc's {beta,stable}-{nominated,accepted} notify-Zulip triggers #140909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use new form for T-rustdoc's {beta,stable}-{nominated,accepted} notify-Zulip triggers #140909

wants to merge 1 commit into from
+4 −4

Conversation

fmease
Copy link
Member

@fmease fmease commented May 10, 2025

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025
@fmease fmease added the T-triagebot Relevant to the triagebot team, which will review and decide on the PR/issue. label May 10, 2025
@apiraino
Copy link
Contributor

@fmease do you have privileges to push #140397 in a rollup? I guess either this patch or mine will need a rebase.

@fmease
Copy link
Member Author

fmease commented May 11, 2025 •
edited
Loading

I'm fine either way, I can also drop the FIXME removals so you don't need to deal with it.

Re. the T-compiler PR, ofc me or you could put it into the queue since one team lead has already approved but I'm not sure if you'd like to wait for the second one, too?

@bors

This comment was marked as resolved.

Sign in to view
@fmease fmease force-pushed the modern-notif-backport-rustdoc branch from bcbfe43 to 42d3ba7 Compare May 12, 2025 11:46
@fmease
Copy link
Member Author

fmease commented May 12, 2025

I take this as an approval.
@bors r=apiraino rollup

@bors
Copy link
Collaborator

bors commented May 12, 2025

📌 Commit 42d3ba7 has been approved by apiraino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2025
@bors
Auto merge of rust-lang#140909 - fmease:modern-notif-backport-rustdoc…
ad1f98f 
…, r=apiraino

Use new form for T-rustdoc's {beta,stable}-{nominated,accepted} notify-Zulip triggers

Applies [#t-rustdoc > PSA: New actions on backport notifs @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/PSA.3A.20New.20actions.20on.20backport.20notifs/near/514823133).
Complements rust-lang#140397.

r? `@apiraino` or T-triagebot
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit 42d3ba7 with merge ad1f98f...

@bors
Copy link
Collaborator

bors commented May 12, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apiraino apiraino

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-triagebot Relevant to the triagebot team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmease @rustbot @apiraino @bors