Skip to content

Rollup of 3 pull requests #140915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 11, 2025
Merged

Rollup of 3 pull requests #140915

merged 6 commits into from
May 11, 2025

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

apiraino and others added 6 commits April 28, 2025 18:31
@apiraino
Add T-compiler backports Zulip notifications
3f4e535
@dpaoliello
Enable non-leaf Frame Pointers for Arm64EC Windows
35679ba
@mu001999
Warn when #[export_name] is used with generic functions
0de994a
@matthiaskrgr
Rollup merge of rust-lang#140397 - apiraino:t-compiler-backports-zuli…
05dd156 
…p-notifications, r=davidtwco

Add T-compiler backports Zulip notifications

This patch make it so, that the triagebot willl send notifications to the Zulip channel [#t-compiler/backports](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports) when a label `{stable-beta}-nominated` is added to beta or stable backport pull request. Requirement to trigger this notification is that the pull request be labeled `T-compiler`.

Note: Zulip notifications can send notifications also on other events (`message_on_close` and `message_on_reopen`) but I omitted them for now, I am not yet sure we need them.

r? `@davidtwco`
@matthiaskrgr
Rollup merge of rust-lang#140851 - mu001999-contrib:new-lint, r=bjorn3
5f55d0d 
Warn when `#[export_name]` is used with generic functions

Fixes rust-lang#140742
@matthiaskrgr
Rollup merge of rust-lang#140862 - dpaoliello:arm64ecfp, r=wesleywiser
4d3c472 
Enable non-leaf Frame Pointers for Arm64EC Windows

This was enabled for native Arm64 via rust-lang#140828

r? `@workingjubilee`
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 11, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented May 11, 2025

📌 Commit 4d3c472 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2025
@bors
Copy link
Collaborator

bors commented May 11, 2025

⌛ Testing commit 4d3c472 with merge 3528a5b...

@bors
Copy link
Collaborator

bors commented May 11, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 3528a5b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2025
@bors bors merged commit 3528a5b into rust-lang:master May 11, 2025
1 check passed
@rustbot rustbot added this to the 1.89.0 milestone May 11, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#140397 Add T-compiler backports Zulip notifications d027eeb3c5758ab4d6688efe888bec00269e710a (link)
#140851 Warn when #[export_name] is used with generic functions ae4bdb2acb8df3e58e4e158a83282d47bcdbe9cd (link)
#140862 Enable non-leaf Frame Pointers for Arm64EC Windows 832faffd40acd3e30f0590f2d66d526853fc33df (link)

previous master: 16c1c54a29

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions GitHub Actions
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 16c1c54 (parent) -> 3528a5b (this PR)

Test differences

Show 38 test diffs

Stage 1

  • [ui] tests/ui/generics/export-name-on-generics.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/generics/export-name-on-generics.rs: [missing] -> pass (J1)

Additionally, 36 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3528a5b76db3501d8835d7a154accf77528b96c9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4361.9s -> 5315.8s (21.9%)
  2. dist-apple-various: 6057.3s -> 7234.9s (19.4%)
  3. dist-x86_64-apple: 7983.3s -> 9332.1s (16.9%)
  4. x86_64-apple-1: 8055.0s -> 7288.9s (-9.5%)
  5. x86_64-mingw-1: 8869.9s -> 9570.5s (7.9%)
  6. i686-msvc-1: 9162.8s -> 9801.1s (7.0%)
  7. x86_64-gnu-llvm-20-1: 5188.6s -> 5542.9s (6.8%)
  8. aarch64-apple: 3653.8s -> 3865.9s (5.8%)
  9. dist-arm-linux: 5122.8s -> 5369.9s (4.8%)
  10. x86_64-msvc-1: 8941.4s -> 8612.7s (-3.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request May 11, 2025
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3528a5b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.6%, secondary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-1.5%, -0.5%] 3
Improvements ✅
(secondary)		 -3.7% [-5.3%, -1.8%] 3
All ❌✅ (primary) -0.6% [-1.5%, 0.5%] 4

Cycles

Results (primary 0.5%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [0.5%, 0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.277s -> 773.066s (0.10%)
Artifact size: 365.37 MiB -> 365.42 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @bors @rust-timer @rustbot @apiraino @dpaoliello @mu001999