Skip to content

Commit 05dd156

Browse files
authored
Rollup merge of #140397 - apiraino:t-compiler-backports-zulip-notifications, r=davidtwco
Add T-compiler backports Zulip notifications This patch make it so, that the triagebot willl send notifications to the Zulip channel [#t-compiler/backports](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports) when a label `{stable-beta}-nominated` is added to beta or stable backport pull request. Requirement to trigger this notification is that the pull request be labeled `T-compiler`. Note: Zulip notifications can send notifications also on other events (`message_on_close` and `message_on_reopen`) but I omitted them for now, I am not yet sure we need them. r? `@davidtwco`
2 parents fd6626d + 3f4e535 commit 05dd156

File tree

1 file changed

+35
-12
lines changed

1 file changed

+35
-12
lines changed

triagebot.toml

+35-12
Original file line numberDiff line numberDiff line change
@@ -611,9 +611,6 @@ message_on_remove = "Issue #{number}'s prioritization request has been removed."
611611
message_on_close = "Issue #{number} has been closed while requested for prioritization."
612612
message_on_reopen = "Issue #{number} has been reopened."
613613

614-
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
615-
# At the moment, the beta-nominated+T-rustdoc action fully occupies the beta-nominated slot
616-
# preventing others from adding more beta-nominated actions.
617614
[notify-zulip."beta-nominated"]
618615
required_labels = ["T-rustdoc"]
619616
zulip_stream = 266220 # #t-rustdoc
@@ -635,9 +632,6 @@ message_on_remove = "PR #{number}'s beta-nomination has been removed."
635632
message_on_close = "PR #{number} has been closed. Thanks for participating!"
636633
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
637634

638-
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
639-
# At the moment, the beta-accepted+T-rustdoc action fully occupies the beta-accepted slot
640-
# preventing others from adding more beta-accepted actions.
641635
[notify-zulip."beta-accepted"]
642636
required_labels = ["T-rustdoc"]
643637
zulip_stream = 266220 # #t-rustdoc
@@ -648,9 +642,6 @@ message_on_remove = "PR #{number}'s beta-acceptance has been **removed**."
648642
message_on_close = "PR #{number} has been closed. Thanks for participating!"
649643
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
650644

651-
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
652-
# At the moment, the stable-nominated+T-rustdoc action fully occupies the stable-nominated slot
653-
# preventing others from adding more stable-nominated actions.
654645
[notify-zulip."stable-nominated"]
655646
required_labels = ["T-rustdoc"]
656647
zulip_stream = 266220 # #t-rustdoc
@@ -673,9 +664,6 @@ message_on_remove = "PR #{number}'s stable-nomination has been removed."
673664
message_on_close = "PR #{number} has been closed. Thanks for participating!"
674665
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
675666

676-
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
677-
# At the moment, the stable-accepted+T-rustdoc action fully occupies the stable-accepted slot
678-
# preventing others from adding more stable-accepted actions.
679667
[notify-zulip."stable-accepted"]
680668
required_labels = ["T-rustdoc"]
681669
zulip_stream = 266220 # #t-rustdoc
@@ -696,6 +684,41 @@ message_on_remove = "Issue #{number}'s nomination has been removed. Thanks all f
696684
message_on_close = "Issue #{number} has been closed. Thanks for participating!"
697685
message_on_reopen = "Issue #{number} has been reopened. Pinging @*T-types*."
698686

687+
[notify-zulip."beta-nominated".compiler]
688+
required_labels = ["T-compiler"]
689+
zulip_stream = 474880 # #t-compiler/backports
690+
topic = "#{number}: beta-nominated"
691+
message_on_add = [
692+
"""\
693+
@**channel** PR #{number} "{title}" has been nominated for beta backport.
694+
""",
695+
"""\
696+
/poll Approve beta backport of #{number}?
697+
approve
698+
decline
699+
don't know
700+
""",
701+
]
702+
message_on_remove = "PR #{number}'s beta-nomination has been removed."
703+
704+
[notify-zulip."stable-nominated".compiler]
705+
required_labels = ["T-compiler"]
706+
zulip_stream = 474880 # #t-compiler/backports
707+
topic = "#{number}: stable-nominated"
708+
message_on_add = [
709+
"""\
710+
@**channel** PR #{number} "{title}" has been nominated for stable backport.
711+
""",
712+
"""\
713+
/poll Approve stable backport of #{number}?
714+
approve
715+
approve (but does not justify new dot release on its own)
716+
decline
717+
don't know
718+
""",
719+
]
720+
message_on_remove = "PR #{number}'s stable-nomination has been removed."
721+
699722
[notify-zulip."A-edition-2021"]
700723
required_labels = ["C-bug"]
701724
zulip_stream = 268952 # #edition

0 commit comments

Comments
 (0)