feat(proguard): Remove release association arguments #2876
+19
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
added
the
v3.0
Contributor
|
loewenheim
approved these changes
Oct 28, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
2 times, most recently
from
0f1e80e to
39214c1
Compare
szokeasaurusrex
changed the base branch from
graphite-base/2876
to
szokeasaurusrex/server-options-nonzerousize
Member
Author
This was referenced Oct 30, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
39214c1 to
78c4afb
Compare
szokeasaurusrex
changed the base branch from
szokeasaurusrex/server-options-nonzerousize
to
graphite-base/2876
szokeasaurusrex
changed the base branch from
graphite-base/2876
to
szokeasaurusrex/immutable-mappings
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
78c4afb to
83f7c20
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/immutable-mappings
branch
from
23eae8b to
4cda688
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
2 times, most recently
from
da8a59b to
482ec10
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
482ec10 to
9918aaa
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 10, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. ### Description Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. ### Issues - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- #### Reminders - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
9918aaa to
2b626ed
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
2b626ed to
890bf74
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Uploads bypass `--no-upload` protection.
The --no-upload flag is ignored when chunk uploading is enabled via SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD=1. The chunk upload code path always uploads files regardless of the flag, while the legacy upload path correctly checks and respects it. This breaks the documented behavior that --no-upload disables the actual upload.
src/commands/upload_proguard.rs#L174-L189
sentry-cli/src/commands/upload_proguard.rs
Lines 174 to 189 in 890bf74
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 10, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 11, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
890bf74 to
199eab5
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 11, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
2 times, most recently
from
4f214b4 to
51273ea
Compare
This was referenced Nov 11, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 12, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
51273ea to
962a04a
Compare
This was referenced Nov 12, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 19, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
962a04a to
106590d
Compare
This was referenced Nov 19, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major. Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release. This change also removes any code that had been called when these flags were specified. - Resolves #2868 - Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release) <!-- - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-release-proguard-flags
branch
from
106590d to
e5cc03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
--app-id,--version, and--version-codearguments to thesentry-cli upload-proguardcommand. Users currently using these arguments should simply stop using them. With this change, we also no longer wait for assembly of the mapping to finish on the backend; previously we needed to wait to associate the release.This change also removes any code that had been called when these flags were specified.
Issues