ref(sourcemaps): UploadContext always has projects
#2959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2025
Member
Author
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 14, 2025
### Description Following #2956, the `UploadContext` struct's `projects` field is always `Some`, indicating we have at least one project. Here, we change the type from `Option<NonEmptySlice>` to `NonEmptySlice` to indicate that we always have a project set.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/projects-always-there
branch
from
b854714 to
96e19ab
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/projects-always-there
branch
from
96e19ab to
871b222
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-files-commands
branch
2 times, most recently
from
c7b4f4b to
0ed0f05
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/projects-always-there
branch
from
871b222 to
929ca90
Compare
loewenheim
approved these changes
Nov 14, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 19, 2025
### Description Following #2956, the `UploadContext` struct's `projects` field is always `Some`, indicating we have at least one project. Here, we change the type from `Option<NonEmptySlice>` to `NonEmptySlice` to indicate that we always have a project set.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-files-commands
branch
from
0ed0f05 to
b8cb3b3
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/projects-always-there
branch
from
929ca90 to
2c2ea91
Compare
This was referenced Nov 19, 2025
### Description Following #2956, the `UploadContext` struct's `projects` field is always `Some`, indicating we have at least one project. Here, we change the type from `Option<NonEmptySlice>` to `NonEmptySlice` to indicate that we always have a project set.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/projects-always-there
branch
from
2c2ea91 to
be26c24
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-files-commands
branch
from
b8cb3b3 to
e39664f
Compare
szokeasaurusrex
added
the
v3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #2956, the
UploadContextstruct'sprojectsfield is alwaysSome, indicating we have at least one project.Here, we change the type from
Option<NonEmptySlice>toNonEmptySliceto indicate that we always have a project set.