ref(chunks): Make get_sha1_checksums infallible
#2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
szokeasaurusrex
force-pushed
the
10-30-ref_chunks_get_sha1_checksums_infallible
branch
from
2676dd1 to
f491da4
Compare
szokeasaurusrex
changed the title
get_sha1_checksums infallibleget_sha1_checksums infallible
This was referenced Oct 30, 2025
This was referenced Oct 30, 2025
loewenheim
approved these changes
Nov 3, 2025
Refactor `get_sha1_checksums` to be infallible by using `NonZeroUsize` for the chunk size. Is the only possible failure reason was the chunk size being zero, the method no longer needs to return a `Result`. This change will slightly simplify the implementation for #2328.
szokeasaurusrex
force-pushed
the
10-30-ref_chunks_get_sha1_checksums_infallible
branch
from
f491da4 to
3d82836
Compare
szokeasaurusrex
deleted the
10-30-ref_chunks_get_sha1_checksums_infallible
branch
This was referenced Nov 6, 2025
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
get_sha1_checksumsto be infallible by usingNonZeroUsizefor the chunk size. Is the only possible failure reason was the chunk size being zero, the method no longer needs to return aResult.This change will slightly simplify the implementation for #2328.
Issues