ref(chunks): Use NonZeroUsize in ChunkServerOptions
#2895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
loewenheim
approved these changes
Oct 30, 2025
This was referenced Oct 30, 2025
Builds on the parent PRs by declaring `chunk_size` as `NonZeroUsize` on the `ChunkServerOptions` struct. This way, `serde` already will validate the value when deserializing; no further checks against zero are needed.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/chunks-from-infallible
branch
from
5345e5d to
5b3a9bf
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/server-options-nonzerousize
branch
from
e747c77 to
07fb49f
Compare
Base automatically changed from
szokeasaurusrex/chunks-from-infallible
to
master
November 3, 2025 10:59
szokeasaurusrex
deleted the
szokeasaurusrex/server-options-nonzerousize
branch
This was referenced Nov 6, 2025
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on the parent PRs by declaring
chunk_sizeasNonZeroUsizeon theChunkServerOptionsstruct. This way,serdealready will validate the value when deserializing; no further checks against zero are needed.Issues