Improve ergonomics of platform_support's Instant
#17577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to my friend https://github.com/repnop for helping me understand how to deal with function pointers in `unsafe` environments Co-authored-by: Wesley Norris <[email protected]>
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
BenjaminBrienen
added
D-Trivial
bushrat011899
approved these changes
Jan 28, 2025
Thank YOU for all the hard work championing Bevy's |
BenjaminBrienen
added
S-Ready-For-Final-Review
BD103
approved these changes
Jan 29, 2025
|
The changes look good, and the demo video was super cool! (Now I want a Playdate ^^) |
mockersf
approved these changes
Feb 2, 2025
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - Make working with `bevy_time` more ergonomic in `no_std` environments. Currently `bevy_time` expects the getter in environments where time can't be obtained automatically via the instruction set or the standard library to be of type `*mut fn() -> Duration`. [`fn()`](https://doc.rust-lang.org/beta/std/primitive.fn.html) is already a function pointer, so `*mut fn()` is a _pointer to a function pointer_. This is harder to use and error prone since creating a pointer out of something like `&mut fn() -> Duration` when the lifetime of the reference isn't static will lead to an undefined behavior once the reference is freed ## Solution - Accept a `fn() -> Duration` instead ## Testing - I made a whole game on the Playdate that relies on `bevy_time` heavily, see: [bevydate_time](https://github.com/Mathspy/bevydate/blob/1b4f02adcde079cf9757fd3c7d20331c9ab04513/src/lib.rs#L510-L546) for usage of the Instant's getter. --- ## Showcase <details> <summary>Click to view showcase</summary> https://github.com/user-attachments/assets/f687847f-6b62-4322-95f3-c908ada3db30 </details> ## Migration Guide This is a breaking change but it's not for people coming from Bevy v0.15 ### Small thank you note Thanks to my friend https://github.com/repnop for helping me understand how to deal with function pointers in `unsafe` environments Co-authored-by: Wesley Norris <[email protected]>
joshua-holmes
pushed a commit
to joshua-holmes/bevy
that referenced
this pull request
Feb 5, 2025
# Objective - Make working with `bevy_time` more ergonomic in `no_std` environments. Currently `bevy_time` expects the getter in environments where time can't be obtained automatically via the instruction set or the standard library to be of type `*mut fn() -> Duration`. [`fn()`](https://doc.rust-lang.org/beta/std/primitive.fn.html) is already a function pointer, so `*mut fn()` is a _pointer to a function pointer_. This is harder to use and error prone since creating a pointer out of something like `&mut fn() -> Duration` when the lifetime of the reference isn't static will lead to an undefined behavior once the reference is freed ## Solution - Accept a `fn() -> Duration` instead ## Testing - I made a whole game on the Playdate that relies on `bevy_time` heavily, see: [bevydate_time](https://github.com/Mathspy/bevydate/blob/1b4f02adcde079cf9757fd3c7d20331c9ab04513/src/lib.rs#L510-L546) for usage of the Instant's getter. --- ## Showcase <details> <summary>Click to view showcase</summary> https://github.com/user-attachments/assets/f687847f-6b62-4322-95f3-c908ada3db30 </details> ## Migration Guide This is a breaking change but it's not for people coming from Bevy v0.15 ### Small thank you note Thanks to my friend https://github.com/repnop for helping me understand how to deal with function pointers in `unsafe` environments Co-authored-by: Wesley Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_timemore ergonomic inno_stdenvironments.Currently
bevy_timeexpects the getter in environments where time can't be obtained automatically via the instruction set or the standard library to be of type*mut fn() -> Duration.fn()is already a function pointer, so*mut fn()is a pointer to a function pointer. This is harder to use and error prone since creating a pointer out of something like&mut fn() -> Durationwhen the lifetime of the reference isn't static will lead to an undefined behavior once the reference is freedSolution
fn() -> DurationinsteadTesting
bevy_timeheavily, see: bevydate_time for usage of the Instant's getter.Showcase
Click to view showcase
test2.mp4
Migration Guide
This is a breaking change but it's not for people coming from Bevy v0.15
Small thank you note
Thanks to my friend https://github.com/repnop for helping me understand how to deal with function pointers in
unsafeenvironments