-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std
support to bevy_input
#16995
Changes from all commits
9f22b3a
1bdca8d
603614e
d1a995d
eb93146
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,8 +72,14 @@ use bevy_ecs::{ | |
event::{Event, EventReader}, | ||
system::ResMut, | ||
}; | ||
|
||
#[cfg(feature = "bevy_reflect")] | ||
use bevy_reflect::Reflect; | ||
|
||
#[cfg(not(feature = "smol_str"))] | ||
use alloc::string::String as SmolStr; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cursed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just avoids further changing code without reason, but I do agree this isn't pretty haha. I'm hoping the PR I've made upstream will be worked-on/accepted so we can just remove this feature gate entirely. |
||
|
||
#[cfg(feature = "smol_str")] | ||
use smol_str::SmolStr; | ||
|
||
#[cfg(all(feature = "serialize", feature = "bevy_reflect"))] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that the
bevy_math/rand
feature just disappeared during these changes.Is that intentional? (I mean I don't see a reason for bevy_input to need random numbers.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I deliberately left that feature off since I couldn't see anything in
bevy_input
that actually needed it.