refactor: split labActions into story, series and comic modules - #38
Merged
Conversation
Keep Story (and its setState allowlist) in labActions.ts. Move Series and Comics implementations behind a barrel so later slice PRs no longer have to edit the same 2.6k file. Shared name/duration helpers live in labActionHelpers.ts.
PR Review — Loreframe StudioRisk: medium Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
This was referenced Sep 1, 2026
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e2404da. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Troceo mínimo del hotspot
labActions.ts(Paso 3, primer PR de lógica).labActions.tsse queda con Story Lab + stage Director + el barrel.seriesLabActions.ts— episodios, plan, render, review, assembly, canon.comicLabActions.ts— create / generate / panel.labActionHelpers.ts—normalizeName, duración, personajes por defecto,showLab.applicationAdapterssigue importando./labActions. Cero JSX. Cero cambio de contrato JSON.El gate
agentCapabilityPortsactualiza el grafo delabActions.ts. La allowlist deuseStore.setStateno cambia: sigue enstageStoryVideo/stageStoryMusicVideo.Por qué
Sin este corte, Story/Series/Comics no pueden ir en PRs disjuntos.
Verificación
npm test— 447 pass.Dueño del merge: humano. No auto-merge.
Note
Low Risk
Mechanical file split with barrel re-exports; no agent JSON contract or runtime behavior changes intended.
Overview
Refactors the oversized
labActions.tsby moving Series Lab and Comic Lab agent handlers intoseriesLabActions.tsandcomicLabActions.ts, with shared utilities inlabActionHelpers.ts.labActions.tsnow holds Story Lab, Director staging/start flows, and re-exports the series and comic symbols so existingimport('./labActions')call sites stay unchanged. Logic in the extracted modules is a move, not a rewrite.The
agentCapabilityPortstest updates the allowed import graph:labActionsmay depend on the new modules instead of pulling comic/series internals directly.Reviewed by Cursor Bugbot for commit e2404da. Configure here.