Skip to content

refactor: move Video Editor actions into the video-editor slice - #41

Merged
IAnMove merged 1 commit into
mainfrom
refactor/paso3-video-editor
Sep 1, 2026
Merged

refactor: move Video Editor actions into the video-editor slice#41
IAnMove merged 1 commit into
mainfrom
refactor/paso3-video-editor

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

Slice Video Editor (Paso 3).

  • ui/src/features/video-editor/{actions,commands,adapters}.ts
  • features/agent/videoEditorActions.ts reexporta.
  • Allowlist temporal: video-editor/actions.tsagentContract.

Cero JSX. Independiente de #38. El test de puertos también lo tocan #39 y #40: mezclar en orden y resolver el allowlist si GitHub marca conflicto.

Verificación

agentCapabilityPorts + tests de timeline/handoff: pass.

Dueño del merge: humano. No auto-merge.


Note

Low Risk
Mechanical file move with a re-export shim; behavior and agent import paths are unchanged, with only an architectural allowlist test update.

Overview
Relocates all Video Editor agent execution logic from features/agent/videoEditorActions.ts into features/video-editor/actions.ts, with relative imports to editorDraft, editorTimeline, and agentContract from the video-editor feature folder.

The old agent path becomes a one-line re-export (export * from '../video-editor/actions'), so existing agentActions imports and dynamic loads of videoEditorActions keep working without graph changes in this PR.

Adds a small video-editor command/adapters surface: commands.ts aliases the existing action types as *Command, and adapters.ts exposes slice-local names (createProject, addClips, exportProject, etc.) that delegate to the moved *AgentVideoEditor* functions—prep for later capability wiring.

Updates agentCapabilityPorts to allowlist the new cross-slice dependency video-editor/actions.ts../agent/agentContract (documented as temporary until the slice boundary tightens).

Reviewed by Cursor Bugbot for commit 23a832b. Configure here.

Leave a reexport in features/agent. The ports gate names the remaining
agentContract import until execution reports live outside Agent Mode.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 5 file(s); +381/-312; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/video-editor/actions.ts, ui/src/features/video-editor/adapters.ts, ui/src/features/video-editor/commands.ts
  • modified: ui/src/features/agent/videoEditorActions.ts, ui/tests/agentCapabilityPorts.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

1 similar comment
@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 23a832b. Configure here.

@IAnMove
IAnMove merged commit 5e6ea5e into main Sep 1, 2026
5 checks passed
@IAnMove
IAnMove deleted the refactor/paso3-video-editor branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant