refactor: move Video Editor actions into the video-editor slice - #41
Merged
Conversation
Leave a reexport in features/agent. The ports gate names the remaining agentContract import until execution reports live outside Agent Mode.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review |
1 similar comment
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 23a832b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Slice Video Editor (Paso 3).
ui/src/features/video-editor/{actions,commands,adapters}.tsfeatures/agent/videoEditorActions.tsreexporta.video-editor/actions.ts→agentContract.Cero JSX. Independiente de #38. El test de puertos también lo tocan #39 y #40: mezclar en orden y resolver el allowlist si GitHub marca conflicto.
Verificación
agentCapabilityPorts+ tests de timeline/handoff: pass.Dueño del merge: humano. No auto-merge.
Note
Low Risk
Mechanical file move with a re-export shim; behavior and agent import paths are unchanged, with only an architectural allowlist test update.
Overview
Relocates all Video Editor agent execution logic from
features/agent/videoEditorActions.tsintofeatures/video-editor/actions.ts, with relative imports toeditorDraft,editorTimeline, andagentContractfrom the video-editor feature folder.The old agent path becomes a one-line re-export (
export * from '../video-editor/actions'), so existingagentActionsimports and dynamic loads ofvideoEditorActionskeep working without graph changes in this PR.Adds a small video-editor command/adapters surface:
commands.tsaliases the existing action types as*Command, andadapters.tsexposes slice-local names (createProject,addClips,exportProject, etc.) that delegate to the moved*AgentVideoEditor*functions—prep for later capability wiring.Updates
agentCapabilityPortsto allowlist the new cross-slice dependencyvideo-editor/actions.ts→../agent/agentContract(documented as temporary until the slice boundary tightens).Reviewed by Cursor Bugbot for commit 23a832b. Configure here.