Skip to content

refactor: move CharacterKit actions into the characters slice - #40

Merged
IAnMove merged 1 commit into
mainfrom
refactor/paso3-character-kit
Sep 1, 2026
Merged

refactor: move CharacterKit actions into the characters slice#40
IAnMove merged 1 commit into
mainfrom
refactor/paso3-character-kit

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

Slice CharacterKit (Paso 3).

  • ui/src/features/characters/{actions,commands,adapters}.ts
  • features/agent/characterKitActions.ts reexporta.
  • El gate nombra los tres imports temporales hacia agent (agentContract, wizardLabSession, queueActions).

Cero JSX. Independiente de #38 (labActions) y de #39 (workspaces), salvo el mismo test de puertos: mezclar #39 y este PR puede pedir un rebase en SLICE_AGENT_IMPORT_ALLOWLIST vs SET_STATE_ALLOWLIST.

Verificación

agentCapabilityPorts + tests CharacterKit: pass.

Dueño del merge: humano. No auto-merge.


Note

Low Risk
Structural refactor with a re-export shim; no intended behavior change, only documented temporary agent imports from the characters slice.

Overview
Character Kit agent logic moves from features/agent/characterKitActions.ts into features/characters/actions.ts, with the old agent file reduced to export * from '../characters/actions' so existing imports (e.g. agentActions) keep working without path changes.

The characters slice adds commands.ts (domain-oriented command type aliases) and adapters.ts (thin createKit / openKit / … wrappers over the moved handlers). Implementation is otherwise the same; relative imports now point at ../agent/agentContract, wizardLabSession, and a dynamic ../agent/queueActions for job tracking.

agentCapabilityPorts documents those three cross-slice agent imports under SLICE_AGENT_IMPORT_ALLOWLIST so the port gate stays green after the move.

Reviewed by Cursor Bugbot for commit b7ea945. Configure here.

Leave a reexport in features/agent so capabilityRegistry and adapters
keep working. Temporary slice imports of agentContract, wizardLabSession
and queueActions are named on the ports allowlist.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 5 file(s); +293/-227; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/characters/actions.ts, ui/src/features/characters/adapters.ts, ui/src/features/characters/commands.ts
  • modified: ui/src/features/agent/characterKitActions.ts, ui/tests/agentCapabilityPorts.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit b7ea945. Configure here.

@IAnMove
IAnMove merged commit 298131d into main Sep 1, 2026
5 checks passed
@IAnMove
IAnMove deleted the refactor/paso3-character-kit branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant