refactor: move CharacterKit actions into the characters slice - #40
Merged
Conversation
Leave a reexport in features/agent so capabilityRegistry and adapters keep working. Temporary slice imports of agentContract, wizardLabSession and queueActions are named on the ports allowlist.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b7ea945. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Slice CharacterKit (Paso 3).
ui/src/features/characters/{actions,commands,adapters}.tsfeatures/agent/characterKitActions.tsreexporta.agent(agentContract,wizardLabSession,queueActions).Cero JSX. Independiente de #38 (labActions) y de #39 (workspaces), salvo el mismo test de puertos: mezclar #39 y este PR puede pedir un rebase en
SLICE_AGENT_IMPORT_ALLOWLISTvsSET_STATE_ALLOWLIST.Verificación
agentCapabilityPorts+ tests CharacterKit: pass.Dueño del merge: humano. No auto-merge.
Note
Low Risk
Structural refactor with a re-export shim; no intended behavior change, only documented temporary agent imports from the characters slice.
Overview
Character Kit agent logic moves from
features/agent/characterKitActions.tsintofeatures/characters/actions.ts, with the old agent file reduced toexport * from '../characters/actions'so existing imports (e.g.agentActions) keep working without path changes.The characters slice adds
commands.ts(domain-oriented command type aliases) andadapters.ts(thincreateKit/openKit/ … wrappers over the moved handlers). Implementation is otherwise the same; relative imports now point at../agent/agentContract,wizardLabSession, and a dynamic../agent/queueActionsfor job tracking.agentCapabilityPortsdocuments those three cross-slice agent imports underSLICE_AGENT_IMPORT_ALLOWLISTso the port gate stays green after the move.Reviewed by Cursor Bugbot for commit b7ea945. Configure here.