Skip to content

refactor: move workspace commands out of Agent Mode - #39

Merged
IAnMove merged 1 commit into
mainfrom
refactor/paso3-workspaces
Sep 1, 2026
Merged

refactor: move workspace commands out of Agent Mode#39
IAnMove merged 1 commit into
mainfrom
refactor/paso3-workspaces

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

Slice Workspaces (Paso 3).

  • Implementación en ui/src/features/workspaces/{actions,commands,adapters}.ts.
  • features/agent/workspaceActions.ts reexporta para no tocar el registry todavía.
  • Allowlist useStore.setState en el mago: 8 → 7 (authoritativeWorkspaces sale de features/agent).

Cero JSX. Independiente del troceo de labActions (#38).

Verificación

agentCapabilityPorts + tests de workspaces: pass.

Dueño del merge: humano. No auto-merge.


Note

Low Risk
Mechanical module move with a re-export shim; no new auth or API behavior, only architecture and test allowlist updates.

Overview
Workspace select/create logic moves from features/agent/workspaceActions.ts into a new features/workspaces slice (actions.ts, plus typed commands.ts and thin adapters.ts wrappers). Behavior and Spanish user-facing messages stay the same; authoritativeWorkspaces and its direct useStore.setState call now live outside Agent Mode.

Agent Mode keeps a stable surface: workspaceActions.ts only re-exports from ../workspaces/actions, so existing dynamic imports and navigationQueueCapabilities do not need registry changes in this PR.

The agentCapabilityPorts gate is tightened: the useStore.setState allowlist drops workspaceActions / authoritativeWorkspaces, and the expected direct-write count goes 8 → 7.

Reviewed by Cursor Bugbot for commit 7daff61. Configure here.

Keep a one-line agent reexport so the registry does not change yet.
The slice now owns actions, commands and adapters; the setState
allowlist shrinks because the write left features/agent.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 5 file(s); +67/-50; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/workspaces/actions.ts, ui/src/features/workspaces/adapters.ts, ui/src/features/workspaces/commands.ts
  • modified: ui/src/features/agent/workspaceActions.ts, ui/tests/agentCapabilityPorts.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7daff61. Configure here.

@IAnMove
IAnMove merged commit 258cfb0 into main Sep 1, 2026
5 checks passed
@IAnMove
IAnMove deleted the refactor/paso3-workspaces branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant