refactor: move workspace commands out of Agent Mode - #39
Merged
Conversation
Keep a one-line agent reexport so the registry does not change yet. The slice now owns actions, commands and adapters; the setState allowlist shrinks because the write left features/agent.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
This was referenced Sep 1, 2026
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7daff61. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Slice Workspaces (Paso 3).
ui/src/features/workspaces/{actions,commands,adapters}.ts.features/agent/workspaceActions.tsreexporta para no tocar el registry todavía.useStore.setStateen el mago: 8 → 7 (authoritativeWorkspacessale defeatures/agent).Cero JSX. Independiente del troceo de
labActions(#38).Verificación
agentCapabilityPorts+ tests de workspaces: pass.Dueño del merge: humano. No auto-merge.
Note
Low Risk
Mechanical module move with a re-export shim; no new auth or API behavior, only architecture and test allowlist updates.
Overview
Workspace select/create logic moves from
features/agent/workspaceActions.tsinto a newfeatures/workspacesslice (actions.ts, plus typedcommands.tsand thinadapters.tswrappers). Behavior and Spanish user-facing messages stay the same;authoritativeWorkspacesand its directuseStore.setStatecall now live outside Agent Mode.Agent Mode keeps a stable surface:
workspaceActions.tsonly re-exports from../workspaces/actions, so existing dynamic imports andnavigationQueueCapabilitiesdo not need registry changes in this PR.The
agentCapabilityPortsgate is tightened: theuseStore.setStateallowlist dropsworkspaceActions/authoritativeWorkspaces, and the expected direct-write count goes 8 → 7.Reviewed by Cursor Bugbot for commit 7daff61. Configure here.