Issue/1933 Create "Migrating" section and move content from Guides #1948
Conversation
| --- | ||
|
|
||
| The following sections describe the major changes from webpack 1 to 2. | ||
|
|
||
| T> Note that there were far fewer changes between 2 and 3, so that migration shouldn't be too bad. If you are running into issues, please see [the changelog](https://github.com/webpack/webpack/releases) for details. | ||
|
|
||
| W> This content may be moved to the blog post in the near future as version 2 has been out for a while. On top of that, version 3 was recently released and version 4 is on the horizon. As noted above, folks should instead to refer to [the changelog](https://github.com/webpack/webpack/releases) for migrations. |
There was a problem hiding this comment.
I dont think this is relevant anymore
There was a problem hiding this comment.
Previous T> Note is also leading to https://github.com/webpack/webpack/releases
There was a problem hiding this comment.
@EugeneHlushko we should merge this against master instead of next branch. Can you update this PR to reflect that?
EugeneHlushko
force-pushed
the
issue/1933
branch
from
7398857 to
3ae1c22
Compare
|
Thank you, it is now |
| --- | ||
|
|
||
| The following sections describe the major changes from webpack 1 to 2. | ||
|
|
||
| T> Note that there were far fewer changes between 2 and 3, so that migration shouldn't be too bad. If you are running into issues, please see [the changelog](https://github.com/webpack/webpack/releases) for details. | ||
|
|
||
| W> This content may be moved to the blog post in the near future as version 2 has been out for a while. On top of that, version 3 was recently released and version 4 is on the horizon. As noted above, folks should instead to refer to [the changelog](https://github.com/webpack/webpack/releases) for migrations. |
There was a problem hiding this comment.
Take a look at changes done in #1939.
There was a problem hiding this comment.
It will be fine, any of these getting into master first and the other gets rebased
|
@TheLarkInn can you re-approve this one been hanging for some time now |
|
Hi @montogeek , |
|
@EugeneHlushko sure |
EugeneHlushko
force-pushed
the
issue/1933
branch
from
43107b2 to
f5940e1
Compare
|
Failure is known: API rate limit exceeded for 104.154.120.187 Pls finish this one @montogeek |
|
@EugeneHlushko Do you have permission to move your branch to this repo? |
|
@montogeek yes, makes any sense for the finished PRs? thought to create new ones under main repository but merge older ones as is to reduce mess on my side of things |
|
Was trying to make the build pass, it already did. Pinged @TheLarkInn to approve it |
|
Thank you! |
EugeneHlushko
force-pushed
the
issue/1933
branch
from
376cad5 to
359cdf9
Compare
antwar.config.js
Outdated
| @@ -55,7 +55,8 @@ module.exports = { | |||
| 'code-splitting-css': '/guides/code-splitting', | |||
| 'code-splitting-libraries': '/guides/code-splitting', | |||
| 'why-webpack': '/comparison', | |||
| 'production-build': '/guides/production' | |||
| 'production-build': '/guides/production', | |||
| 'migrating': '/migrate/3', | |||
|
Approved. Let's get conflicts resolved and good to go! |
EugeneHlushko
force-pushed
the
issue/1933
branch
from
359cdf9 to
dbdb981
Compare
|
Cool, waiting for build and can merge cc @montogeek |
|
Thanks |
Create "Migrating" section and move content from Guides.
Fixes #1933