-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
content(homepage) Mention 0CJS capability #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f321e8
to
2725f3c
Compare
CC @TheLarkInn would be nice to get your view on this Sean |
That small change is fine but it doesn't feel to sell 0C well enough. Changing it to |
Yes indeed it should be |
src/content/index.md
Outdated
@@ -30,12 +30,15 @@ export default function bar() { | |||
|
|||
<div class="splash__wrap"> | |||
<div class="splash__left"> | |||
__webpack.config.js__ | |||
__Without config__ or provide custom __webpack.config.js__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clean __
from __Without config__
?
I think we only use them with file names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for giving a strong emphasis on 0cjs, we need @TheLarkInn to have a look at this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! We should give emphasis on 0CJS. Not sure if __
is the best way to do it.
@montogeek can you assign a review request on @TheLarkInn pls he doesnt seem to get notifications on comment level |
@sokra can you pls advice on wording here as Sean seems not responsive for last two weeks |
Sorry I've been digging out of my inbox. Okay so I guess you could link it to my talk from JSCONF Iceland which talks about 0CJS! |
https://youtu.be/3Nv9muOkb6k I believe holds the marker to it. We could make a custom expert about it if we needed to. |
hmm ive seen that talk, its good 👍 do you mean linking this specific phrase? |
@TheLarkInn Here's precisely where we talk about 0CJS. https://youtu.be/3Nv9muOkb6k?t=21293 |
18b9ed9
to
9cc9560
Compare
9cc9560
to
8056102
Compare
Rebased it all, it now contains a link to specific time (thx @dhruvdutt and @TheLarkInn) |
Can we merge this if all issues were addressed? |
Some PRs hanging approved for a while, are you trying to merge things one day in the end of the month @montogeek ? |
@EugeneHlushko I wait for more input from other contributors :) |
Thanks! |
Ah got it, maybe makes sense to assign people on approved PRs so they dont get rebased/updated so often due to becoming outdated vs target branch, a good example is #1948 |
As mentioned on #1870 homepage doesnt say that webpack can compile without config
P.S. im not really sure we should make the examples more complicated to match our 0cjs setup, maybe just mention it in other way?
P.P.S Should i add
mode: "production"
to the config snippet?