Skip to content

content(homepage) Mention 0CJS capability #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Mar 6, 2018

As mentioned on #1870 homepage doesnt say that webpack can compile without config

  • Mention on the homepage about 0cjs capability

P.S. im not really sure we should make the examples more complicated to match our 0cjs setup, maybe just mention it in other way?

P.P.S Should i add mode: "production" to the config snippet?

@EugeneHlushko EugeneHlushko force-pushed the feature/homepage-0cjs branch 2 times, most recently from 0f321e8 to 2725f3c Compare March 6, 2018 19:48
@EugeneHlushko
Copy link
Member Author

CC @TheLarkInn would be nice to get your view on this Sean

@EugeneHlushko
Copy link
Member Author

screen shot 2018-03-07 at 9 59 12 am

@montogeek
Copy link
Member

That small change is fine but it doesn't feel to sell 0C well enough.
Also, defaults are src/index.js no src/app.js, so in the case the user just run webpack without any config file an error would appear saying that src/index.js can not be resolved.

Changing it to src/index.js would be better, it is also the name file of the getting starting page.

@EugeneHlushko
Copy link
Member Author

Yes indeed it should be index.js, changed thank you @montogeek
In regard to selling 0cjs thats why i pinged Sean, i think he does this best :)

@@ -30,12 +30,15 @@ export default function bar() {

<div class="splash__wrap">
<div class="splash__left">
__webpack.config.js__
__Without config__ or provide custom __webpack.config.js__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean __ from __Without config__?
I think we only use them with file names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for giving a strong emphasis on 0cjs, we need @TheLarkInn to have a look at this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! We should give emphasis on 0CJS. Not sure if __ is the best way to do it.

@EugeneHlushko
Copy link
Member Author

@montogeek can you assign a review request on @TheLarkInn pls he doesnt seem to get notifications on comment level

@EugeneHlushko
Copy link
Member Author

@sokra can you pls advice on wording here as Sean seems not responsive for last two weeks

@TheLarkInn
Copy link
Member

Sorry I've been digging out of my inbox. Okay so I guess you could link it to my talk from JSCONF Iceland which talks about 0CJS!

@TheLarkInn
Copy link
Member

https://youtu.be/3Nv9muOkb6k I believe holds the marker to it. We could make a custom expert about it if we needed to.

@EugeneHlushko
Copy link
Member Author

hmm ive seen that talk, its good 👍 do you mean linking this specific phrase? Without config @TheLarkInn

@dhruvdutt
Copy link
Member

@TheLarkInn Here's precisely where we talk about 0CJS. https://youtu.be/3Nv9muOkb6k?t=21293

@EugeneHlushko EugeneHlushko force-pushed the feature/homepage-0cjs branch from 18b9ed9 to 9cc9560 Compare March 23, 2018 11:56
@EugeneHlushko EugeneHlushko force-pushed the feature/homepage-0cjs branch from 9cc9560 to 8056102 Compare March 23, 2018 11:59
@EugeneHlushko
Copy link
Member Author

Rebased it all, it now contains a link to specific time (thx @dhruvdutt and @TheLarkInn)

@jeremenichelli
Copy link
Member

Can we merge this if all issues were addressed?

@EugeneHlushko
Copy link
Member Author

Some PRs hanging approved for a while, are you trying to merge things one day in the end of the month @montogeek ?

@montogeek
Copy link
Member

@EugeneHlushko I wait for more input from other contributors :)

@montogeek montogeek merged commit 6fa39c0 into webpack:next Mar 27, 2018
@montogeek
Copy link
Member

Thanks!

@EugeneHlushko
Copy link
Member Author

Ah got it, maybe makes sense to assign people on approved PRs so they dont get rebased/updated so often due to becoming outdated vs target branch, a good example is #1948

@EugeneHlushko EugeneHlushko deleted the feature/homepage-0cjs branch March 27, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants