Skip to content

Issue/1933 Create "Migrating" section and move content from Guides #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions antwar.config.js
Original file line number Diff line number Diff line change
@@ -85,6 +85,12 @@ module.exports = () => ({
layout: () => require('./src/components/Page/Page.jsx').default,
content: () => require.context('./loaders/page-loader!./src/content/contribute', false, /^\.\/.*\.md$/),
},
migrate: {
title: 'Migrate',
url: ({ sectionName, fileName }) => `/${sectionName}/${fileName}/`,
layout: () => require('./src/components/Page/Page.jsx').default,
content: () => require.context('./loaders/page-loader!./src/content/migrate', false, /^\.\/.*\.md$/),
},
vote: () => require('./src/components/Vote/Vote.jsx').default,
organization: () => require('./src/components/Organization/Organization.jsx').default,
'starter-kits': () => require('./src/components/StarterKits/StarterKits.jsx').default,
3 changes: 2 additions & 1 deletion src/components/Navigation/Links.json
Original file line number Diff line number Diff line change
@@ -8,7 +8,8 @@
{ "title": "API", "url": "api" },
{ "title": "Guides", "url": "guides" },
{ "title": "Loaders", "url": "loaders" },
{ "title": "Plugins", "url": "plugins" }
{ "title": "Plugins", "url": "plugins" },
{ "title": "Migrate", "url": "migrate" }
]
},
{
7 changes: 3 additions & 4 deletions src/content/guides/migrating.md → src/content/migrate/3.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Migrating Versions
sort: 15
title: To webpack v2, v3
sort: 1
contributors:
- sokra
- jhnns
@@ -14,14 +14,13 @@ contributors:
- howdy39
- selbekk
- ndelangen
- EugeneHlushko
---

The following sections describe the major changes from webpack 1 to 2.

T> Note that there were far fewer changes between 2 and 3, so that migration shouldn't be too bad. If you are running into issues, please see [the changelog](https://github.com/webpack/webpack/releases) for details.

W> This content may be moved to the blog post in the near future as version 2 has been out for a while. On top of that, version 3 was recently released and version 4 is on the horizon. As noted above, folks should instead to refer to [the changelog](https://github.com/webpack/webpack/releases) for migrations.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is relevant anymore

Copy link
Member Author

@EugeneHlushko EugeneHlushko Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous T> Note is also leading to https://github.com/webpack/webpack/releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at changes done in #1939.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be fine, any of these getting into master first and the other gets rebased



## `resolve.root`, `resolve.fallback`, `resolve.modulesDirectories`

8 changes: 8 additions & 0 deletions src/content/migrate/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
title: Migrate
sort: 1
contributors:
- EugeneHlushko
---

This section contains information about migrating from older versions of webpack to newer ones.
1 change: 1 addition & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
@@ -119,6 +119,7 @@ module.exports = (env) => ({
'development/release-process': '/contribute/release-process/',
'development/how-to-write-a-loader': '/contribute/writing-a-loader/',
'development/how-to-write-a-plugin': '/contribute/writing-a-plugin/',
'migrating': '/migrate/3/',
},
}),
]