-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{chart,scripts}: move datasource test to helm chart #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As helm test
is run as part of ct install
, I guess we can remove the GH action and just rely on the test to be present to verify datasources, which is nice.
Since the check-datasources.sh script got removed, let's cleanup the Makefile target as well.
3844c0e
to
46b7298
Compare
3b31fbd
to
2770578
Compare
fcf48b4
to
6a21c07
Compare
6a21c07
to
8e5b620
Compare
This PR is now doing a bit more than I initially anticipated. In addition to what was primarily being fixed it also changes the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's just address the missing env variables.
Description
Alternative approach to #520 which allows to use
helm test
command to test datasource connectivity. This method may also be used later on to test data ingestion (issue #324).Re-enable datasource test, fixes #517
Fix promql datasource in grafana, fixes #519
Type of change
What type of changes does your code introduce to tobs? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)