Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{chart,scripts}: move datasource test to helm chart #521

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

paulfantom
Copy link
Contributor

Description

Alternative approach to #520 which allows to use helm test command to test datasource connectivity. This method may also be used later on to test data ingestion (issue #324).

Re-enable datasource test, fixes #517
Fix promql datasource in grafana, fixes #519

Type of change

What type of changes does your code introduce to tobs? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

@paulfantom paulfantom requested a review from a team as a code owner August 1, 2022 15:09
@paulfantom paulfantom self-assigned this Aug 1, 2022
Copy link
Contributor

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As helm test is run as part of ct install, I guess we can remove the GH action and just rely on the test to be present to verify datasources, which is nice.

Since the check-datasources.sh script got removed, let's cleanup the Makefile target as well.

@paulfantom paulfantom force-pushed the datasource-fix branch 4 times, most recently from 3844c0e to 46b7298 Compare August 2, 2022 11:53
@paulfantom paulfantom marked this pull request as draft August 2, 2022 12:04
@paulfantom paulfantom force-pushed the datasource-fix branch 4 times, most recently from 3b31fbd to 2770578 Compare August 3, 2022 07:26
@paulfantom paulfantom force-pushed the datasource-fix branch 3 times, most recently from fcf48b4 to 6a21c07 Compare August 3, 2022 08:08
@paulfantom
Copy link
Contributor Author

This PR is now doing a bit more than I initially anticipated. In addition to what was primarily being fixed it also changes the following:

  • CI helm values are limited only to necessary overrides
  • additional lint and e2e make targets were added and now they are also used in CI

@paulfantom paulfantom marked this pull request as ready for review August 3, 2022 08:17
@paulfantom paulfantom requested a review from onprem August 3, 2022 08:17
@paulfantom paulfantom enabled auto-merge August 3, 2022 08:21
Copy link
Contributor

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just address the missing env variables.

chart/ci/default-values.yaml Show resolved Hide resolved
@paulfantom paulfantom requested a review from onprem August 4, 2022 07:40
@paulfantom paulfantom merged commit fc84814 into timescale:main Aug 4, 2022
@paulfantom paulfantom deleted the datasource-fix branch August 4, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasources connections are broken. Re-enable testing datasources
2 participants