Add GH workflow to check if datasources are working #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prem Saraswat <[email protected]>
Signed-off-by: Prem Saraswat <[email protected]>
Signed-off-by: Prem Saraswat <[email protected]>
paulfantom
approved these changes
Aug 1, 2022
paulfantom
suggested changes
Aug 1, 2022
| @@ -0,0 +1,93 @@ | |||
| --- | |||
There was a problem hiding this comment.
Don't include this file as it is not required by current testing strategy.
5 tasks
|
Closing as it has been superseded by #521. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The step to check if datasources are working was removed during the CLI removal PR. This PR adds it back in the form of another GH workflow. We cannot use the e2e test job as before as
ct installimmediately cleans up after itself as well.Fixes #517
Type of change
What type of changes does your code introduce to tobs? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)