Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite unit tests to use helm-unittest #408

Closed
paulfantom opened this issue May 31, 2022 · 1 comment
Closed

Rewrite unit tests to use helm-unittest #408

paulfantom opened this issue May 31, 2022 · 1 comment
Assignees
@onprem
Labels
enhancement Improvement of an existing feature epic/tobs-code-stabilization

Comments

@paulfantom
Copy link
Contributor

What is missing?

We don't have many unit tests for helm chart and thus bugs can slip into releases.

Why do we need it?

Currently we are mixing unit tests and integration tests and require running a kubernetes cluster for tests. This can be simplified by moving unit tests into helm-unittest.

Anything else we need to know?:
@paulfantom paulfantom added the enhancement Improvement of an existing feature label May 31, 2022
@paulfantom paulfantom added this to the 0.12.0 milestone Jun 14, 2022
@paulfantom paulfantom mentioned this issue Jun 22, 2022
Closed
@paulfantom paulfantom removed this from the 0.12.0 milestone Aug 1, 2022
@paulfantom
Copy link
Contributor Author

Since in #521 we introduced a way to test thins functionally, I don't think this is needed at the moment. As such I am closing this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onprem onprem

Labels
enhancement Improvement of an existing feature epic/tobs-code-stabilization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulfantom @onprem