feat(memory): use Vector in PageProtections component#962
Queued
vapourismo wants to merge 1 commit intomainfrom
Queued
feat(memory): use Vector in PageProtections component#962vapourismo wants to merge 1 commit intomainfrom
vapourismo wants to merge 1 commit intomainfrom
Conversation
9 tasks
|
Benchmark results for revision 001c765:
Full results
Compare the results above with those for the default branch. |
0b2fc99 to
7e548e6
Compare
6c2ec75 to
a5dd12e
Compare
a5dd12e to
2cb7b9a
Compare
9 tasks
2cb7b9a to
a4fa45b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
+ Coverage 89.70% 89.90% +0.19%
==========================================
Files 110 110
Lines 22136 22132 -4
Branches 22136 22132 -4
==========================================
+ Hits 19857 19897 +40
+ Misses 1884 1841 -43
+ Partials 395 394 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d8a0a8 to
49a17e3
Compare
thomasathorne
approved these changes
Mar 30, 2026
49a17e3 to
a465155
Compare
NSant215
approved these changes
Mar 30, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the boxed array with
Vectorin thePageProtectionscomponent.Why
This lets us remove the const-generic parameter, which paves the way for making the memory size runtime configurable.
A nice effect of this change is that the memory overhead in
Verifymode is reduced quite a bit.Atom<bool, Verify>is 33 BPageProtections<Verify>is therefore 33 MiB - regardless of whether it's present, blinded or absentPageProtections-> 99 MiB unconditionallyThe
Vectorcomponent has a 104 B footprint inVerifymode when it is completely absent.I am not sure if it's a reference machine glitch, but it looks like there is a +2% TPS bump in it as well.
Manually Testing
Regressions
Using the
Vectorstate component in place of the previous boxed fixed-sized array changes the Merkle tree structure and therefore the hashes and proof serialisation.Tasks for the Author