Skip to content

feat(vector): add CloneState implementation#961

Merged
vapourismo merged 1 commit intomainfrom
ole/push-nqsnvmxywxkv
Mar 30, 2026
Merged

feat(vector): add CloneState implementation#961
vapourismo merged 1 commit intomainfrom
ole/push-nqsnvmxywxkv

Conversation

@vapourismo
Copy link
Copy Markdown
Collaborator

@vapourismo vapourismo commented Mar 27, 2026

What

Implement CloneState for the Vector state component.

Why

I need this for #962.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.65%. Comparing base (9b1c76e) to head (7e548e6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
data/src/components/vector.rs 0.00% 34 Missing ⚠️
data/src/partial_vec.rs 0.00% 11 Missing ⚠️
data/src/clone.rs 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   89.87%   89.65%   -0.23%     
==========================================
  Files         110      110              
  Lines       22084    22129      +45     
  Branches    22084    22129      +45     
==========================================
- Hits        19848    19839       -9     
- Misses       1837     1891      +54     
  Partials      399      399              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vapourismo vapourismo marked this pull request as ready for review March 27, 2026 18:50
@vapourismo vapourismo enabled auto-merge March 27, 2026 18:50
@vapourismo vapourismo force-pushed the ole/push-nqsnvmxywxkv branch from 0b2fc99 to 7e548e6 Compare March 27, 2026 18:52
@github-actions
Copy link
Copy Markdown

Benchmark results for revision 1f181db:

Metric Duration TPS
Mean 1.516895031s 26.370
Worst 1.52440637s 26.240
Best 1.497158295s 26.717
Standard Deviation ±6.169612ms ±0.108
Full results
Run Transfers Duration TPS
1 40 1.51802603s 26.350
2 40 1.52440637s 26.240
3 40 1.51281528s 26.441
4 40 1.523644872s 26.253
5 40 1.515166652s 26.400
6 40 1.515082163s 26.401
7 40 1.514428619s 26.413
8 40 1.516125737s 26.383
9 40 1.522927898s 26.265
10 40 1.519238745s 26.329
11 40 1.52346981s 26.256
12 40 1.522725433s 26.269
13 40 1.51285351s 26.440
14 40 1.520696456s 26.304
15 40 1.508014943s 26.525
16 40 1.519601047s 26.323
17 40 1.516875546s 26.370
18 40 1.518429127s 26.343
19 40 1.516214084s 26.381
20 40 1.497158295s 26.717

Compare the results above with those for the default branch.

@vapourismo vapourismo added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit e1c292b Mar 30, 2026
6 of 7 checks passed
@vapourismo vapourismo deleted the ole/push-nqsnvmxywxkv branch March 30, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants