feat(vector): add index operations without bounds checks#963
Merged
vapourismo merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
|
Benchmark results for revision 6994cb8:
Full results
Compare the results above with those for the default branch. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 89.87% 89.74% -0.14%
==========================================
Files 110 110
Lines 22084 22108 +24
Branches 22084 22108 +24
==========================================
- Hits 19848 19840 -8
- Misses 1837 1869 +32
Partials 399 399 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NSant215
approved these changes
Mar 29, 2026
thomasathorne
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two methods to the
Vectorstate components:index_uncheckedindex_unchecked_mutThese two methods allow you to obtain references to the underlying elements without incurring the cost of a bounds check.
Why
These functions are important for the usage of this state component in performance critical contexts.
See #962 for usage of these methods.
Manually Testing
Tasks for the Author