Fail early for the resource conflicts between the activating controllers

[saikishor]

Fixes: #2758

@urfeex FYI

[bmagyar]

Pretty elegant, thank you!

[saikishor]

Pretty elegant, thank you!

I don't get the failing tests, I'll take a look when I get off the plane.

Thanks

[saikishor]

Sorry for the different committer naming, I did this from a colleagues laptop hahah

[codecov]

Codecov Report

❌ Patch coverage is 88.15789% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.59%. Comparing base (a7e0b3a) to head (eba420d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	71.87%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
- Coverage   89.62%   89.59%   -0.03%     
==========================================
  Files         152      152              
  Lines       17637    17710      +73     
  Branches     1448     1454       +6     
==========================================
+ Hits        15807    15868      +61     
- Misses       1246     1256      +10     
- Partials      584      586       +2     

Flag	Coverage Δ
unittests	89.59% <88.15%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../include/controller_manager/controller_manager.hpp	97.29% <ø> (ø)
...ller_manager/test/test_controller_manager_srvs.cpp	99.34% <100.00%> (+0.02%)	⬆️
...ontroller_manager/test/test_release_interfaces.cpp	90.27% <ø> (ø)
controller_manager/src/controller_manager.cpp	76.87% <71.87%> (-0.12%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[urfeex]

Unfortunately, this does not fix #2758 for me. The output is the same as described in the issue.

[saikishor]

Unfortunately, this does not fix #2758 for me. The output is the same as described in the issue.

Thanks for commenting about it. I'll recheck the tests and try to run UR tests locally.

[saikishor]

@urfeex With the new changes, your issues should be fixed. Please test it and let us know. I ran the UR tests locally and it passed. Please check and let us know tomorrow :)

[urfeex]

That fixes the regression and also looks fine :-) I'll approve with my private account which is in the org.

Thank you very much for addressing this so quickly @saikishor

[saikishor]

That fixes the regression and also looks fine :-) I'll approve with my private account which is in the org.

Thank you very much for addressing this so quickly @saikishor

I'm glad it worked ;)
Thank you for the information.

[christophfroehlich]

LGTM