-
Couldn't load subscription status.
- Fork 373
[Transmissions] Add force interface
#2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transmissions] Add force interface
#2588
Conversation
force and current interfaces
3bd5b9d to
d6a2549
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
==========================================
- Coverage 89.40% 89.38% -0.03%
==========================================
Files 151 151
Lines 17024 17085 +61
Branches 1420 1424 +4
==========================================
+ Hits 15220 15271 +51
- Misses 1250 1255 +5
- Partials 554 559 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
transmission_interface/include/transmission_interface/differential_transmission.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion, we are not sure if the current makes sense at the joint end. It is better to be only on the actuator end the conversion from Nm/N to Amp.
Yeah, I have to agree. I was kinda realizing the same thing when I was coding the differential transmission part. Current does not really make sense at joint level. Will fix. @christophfroehlich Thanks for spotting the typo ( 😭 ). In the end I'll remove all the "curret" related stuff. |
force and current interfacesforce interface to the Transmissions
force interface to the Transmissionsforce interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It is missing the release_notes
|
This pull request is in conflict. Could you fix it @jordan-palacios? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it as it is, and rethink the check possibly in a separate PR.
b674ebb
into
ros-controls:master
(cherry picked from commit b674ebb) # Conflicts: # doc/release_notes.rst
(cherry picked from commit b674ebb) # Conflicts: # doc/release_notes.rst
Follow up on #2310.
Same concept and approach, only this time we add force and current interfaces.
As before, adding these two new interfaces is backwards compatible. If force and current interfaces are not available then the contents from this PR do nothing.