Skip to content

Conversation

@jordan-palacios
Copy link
Member

Follow up on #2310.

Same concept and approach, only this time we add force and current interfaces.

As before, adding these two new interfaces is backwards compatible. If force and current interfaces are not available then the contents from this PR do nothing.

@jordan-palacios jordan-palacios changed the title Feat/force and current interfaces [Transmissions] Add force and current interfaces Sep 29, 2025
@jordan-palacios jordan-palacios changed the title [Transmissions] Add force and current interfaces [Transmissions] Add force and current interfaces Sep 29, 2025
@jordan-palacios jordan-palacios force-pushed the feat/force_and_current_interfaces branch from 3bd5b9d to d6a2549 Compare September 29, 2025 10:56
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.38%. Comparing base (c993e5b) to head (c692024).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ansmission_interface/differential_transmission.hpp 76.19% 3 Missing and 2 partials ⚠️
...ude/transmission_interface/simple_transmission.hpp 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2588      +/-   ##
==========================================
- Coverage   89.40%   89.38%   -0.03%     
==========================================
  Files         151      151              
  Lines       17024    17085      +61     
  Branches     1420     1424       +4     
==========================================
+ Hits        15220    15271      +51     
- Misses       1250     1255       +5     
- Partials      554      559       +5     
Flag Coverage Δ
unittests 89.38% <86.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._interface/test/differential_transmission_test.cpp 99.57% <100.00%> (+0.05%) ⬆️
...ission_interface/test/simple_transmission_test.cpp 100.00% <100.00%> (ø)
...ude/transmission_interface/simple_transmission.hpp 76.38% <55.55%> (-0.89%) ⬇️
...ansmission_interface/differential_transmission.hpp 79.75% <76.19%> (-0.81%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jordan-palacios jordan-palacios marked this pull request as ready for review September 29, 2025 12:02
@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Sep 29, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, we are not sure if the current makes sense at the joint end. It is better to be only on the actuator end the conversion from Nm/N to Amp.

@jordan-palacios
Copy link
Member Author

jordan-palacios commented Oct 8, 2025

After some discussion, we are not sure if the current makes sense at the joint end. It is better to be only on the actuator end the conversion from Nm/N to Amp.

Yeah, I have to agree. I was kinda realizing the same thing when I was coding the differential transmission part. Current does not really make sense at joint level. Will fix.

@christophfroehlich Thanks for spotting the typo ( 😭 ). In the end I'll remove all the "curret" related stuff.

@saikishor saikishor changed the title [Transmissions] Add force and current interfaces [Transmissions] Add force interface to the Transmissions Oct 9, 2025
@saikishor saikishor changed the title [Transmissions] Add force interface to the Transmissions [Transmissions] Add force interface Oct 9, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is missing the release_notes

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2025

This pull request is in conflict. Could you fix it @jordan-palacios?

@saikishor saikishor added the backport-kilted Triggers PR backport to ROS 2 kilted. label Oct 13, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it as it is, and rethink the check possibly in a separate PR.

@christophfroehlich christophfroehlich merged commit b674ebb into ros-controls:master Oct 15, 2025
17 of 18 checks passed
mergify bot pushed a commit that referenced this pull request Oct 15, 2025
(cherry picked from commit b674ebb)

# Conflicts:
#	doc/release_notes.rst
mergify bot pushed a commit that referenced this pull request Oct 15, 2025
(cherry picked from commit b674ebb)

# Conflicts:
#	doc/release_notes.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants