Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2025

Follow up on #2310.

Same concept and approach, only this time we add force and current interfaces.

As before, adding these two new interfaces is backwards compatible. If force and current interfaces are not available then the contents from this PR do nothing.


This is an automatic backport of pull request #2588 done by Mergify.

(cherry picked from commit b674ebb)

# Conflicts:
#	doc/release_notes.rst
@mergify mergify bot added the conflicts label Oct 15, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Oct 15, 2025

Cherry-pick of b674ebb has failed:

On branch mergify/bp/kilted/pr-2588
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit b674ebb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   transmission_interface/include/transmission_interface/differential_transmission.hpp
	modified:   transmission_interface/include/transmission_interface/simple_transmission.hpp
	modified:   transmission_interface/test/differential_transmission_test.cpp
	modified:   transmission_interface/test/simple_transmission_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/release_notes.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (c527e76) to head (3378379).
⚠️ Report is 2 commits behind head on kilted.

Files with missing lines Patch % Lines
...ansmission_interface/differential_transmission.hpp 76.19% 3 Missing and 2 partials ⚠️
...ude/transmission_interface/simple_transmission.hpp 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #2679      +/-   ##
==========================================
- Coverage   89.38%   89.37%   -0.01%     
==========================================
  Files         151      151              
  Lines       17036    17096      +60     
  Branches     1420     1424       +4     
==========================================
+ Hits        15227    15279      +52     
- Misses       1256     1259       +3     
- Partials      553      558       +5     
Flag Coverage Δ
unittests 89.37% <86.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._interface/test/differential_transmission_test.cpp 99.57% <100.00%> (+0.05%) ⬆️
...ission_interface/test/simple_transmission_test.cpp 100.00% <100.00%> (ø)
...ude/transmission_interface/simple_transmission.hpp 76.38% <55.55%> (-0.89%) ⬇️
...ansmission_interface/differential_transmission.hpp 79.75% <76.19%> (-0.81%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich
Copy link
Contributor

@saikishor do we want to break ABI on kilted here?

@saikishor
Copy link
Member

@saikishor do we want to break ABI on kilted here?

Yes, as this is a runtime plugin and also it doesn't have any dependencies using the library. So, shouldn't be a problem at all

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure, I forgot that they are plugins at well.

@christophfroehlich christophfroehlich merged commit 3ff3610 into kilted Oct 16, 2025
13 of 15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-2588 branch October 16, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants