Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some tests of internal API #2801

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Remove some tests of internal API #2801

wants to merge 28 commits into from

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Feb 27, 2025 •
edited
Loading

Closes #1692. Has #2802 cherry-picked in for now.

@MichaelChirico MichaelChirico mentioned this pull request Feb 27, 2025
Open
24 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.22%. Comparing base (e01791f) to head (24e6e54).

Files with missing lines Patch % Lines
R/make_linter_from_regex.R 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
- Coverage   99.59%   99.22%   -0.37%     
==========================================
  Files         125      125              
  Lines        6832     6821      -11     
==========================================
- Hits         6804     6768      -36     
- Misses         28       53      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico changed the title Remove internal API test (make_linter_from_regex) Remove some tests of internal API Feb 27, 2025
@MichaelChirico MichaelChirico mentioned this pull request Feb 27, 2025
Open
@MichaelChirico MichaelChirico marked this pull request as draft February 27, 2025 23:47
@MichaelChirico
Copy link
Collaborator Author

Wait for #2802

@MichaelChirico MichaelChirico mentioned this pull request Feb 28, 2025
Closed
@MichaelChirico MichaelChirico mentioned this pull request Mar 5, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use public interface in tests wherever possible (don't use :::)
2 participants
@MichaelChirico @AshesITR