Add ignore_order= argument to expect_lint() #2802
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2801, I'm trying to rewrite this to use
expect_lint()
, it generates 192 lints, quite cumbersome to ensure the lints are all in the expected order.I am tempted to make
ignore_order=TRUE
the default, actually, I'm not sure how meaningful it is to test the order in which lints are produced. But that would possibly be a breaking change.