Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_order= argument to expect_lint() #2802

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Collaborator

For #2801, I'm trying to rewrite this to use expect_lint(), it generates 192 lints, quite cumbersome to ensure the lints are all in the expected order.

I am tempted to make ignore_order=TRUE the default, actually, I'm not sure how meaningful it is to test the order in which lints are produced. But that would possibly be a breaking change.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (0939d20) to head (5522ae1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2802   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         125      125           
  Lines        6863     6872    +9     
=======================================
+ Hits         6835     6844    +9     
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AshesITR
AshesITR previously approved these changes Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants