Remove some tests of internal API

R/make_linter_from_regex.R

@@ -1,7 +1,7 @@
 make_linter_from_regex <- function(regex,
                                    lint_type,
                                    lint_msg) {
-  function() {
+  function() { # nocov: only run at namespace load time
     Linter(linter_level = "file", function(source_expression) {
       all_matches <- re_matches(
         source_expression[["file_lines"]],
@@ -29,7 +29,7 @@ make_linter_from_regex <- function(regex,
       })
       lints[lengths(lints) > 0L]
     })
-  }
+  } # nocov: ditto opening brace
 }
 
 #' Determine if a regex match is covered by an expression in a source_expression

R/methods.R

@@ -85,39 +85,6 @@ print.lints <- function(x, ...) {
   invisible(x)
 }
 
-trim_output <- function(x, max = 65535L) {
-  # if x is less than the max, just return it
-  if (length(x) <= 0L || nchar(x) <= max) {
-    return(x)
-  }
-
-  # otherwise trim x to the max, then search for the lint starts
-  x <- substr(x, 1L, max)
-
-  re <- rex(
-    "[", except_some_of(":"), ":", numbers, ":", numbers, ":", "]",
-    "(", except_some_of(")"), ")",
-    space,
-    "*", or("style", "warning", "error"), ":", "*",
-    except_some_of("\r\n"), newline,
-    except_some_of("\r\n"), newline,
-    except_some_of("\r\n"), newline,
-    except_some_of("\r\n"), newline,
-    except_some_of("\r\n"), newline
-  )
-
-  lint_starts <- re_matches(x, re, global = TRUE, locations = TRUE)[[1L]]
-
-  # if at least one lint ends before the cutoff, cutoff there, else just use
-  # the cutoff
-  last_end <- lint_starts[NROW(lint_starts), "end"]
-  if (!is.na(last_end)) {
-    substr(x, 1L, last_end)
-  } else {
-    x
-  }
-}
-
 #' @export
 names.lints <- function(x, ...) {
   vapply(x, `[[`, character(1L), "filename")

R/path_utils.R

@@ -57,10 +57,6 @@ is_root_path <- function(path) {
   re_matches(path, root_path_regex)
 }
 
-is_relative_path <- function(path) {
-  re_matches(path, relative_path_regex)
-}
-
 is_path <- function(path) {
   re_matches(path, path_regex)
 }

tests/testthat/test-absolute_path_linter.R

@@ -52,28 +52,6 @@ test_that("is_absolute_path", {
   expect_identical(f(x), y)
 })
 
-
-test_that("is_relative_path", {
-  f <- lintr:::is_relative_path
-
-  x <- character()
-  y <- logical()
-  expect_identical(f(x), y)
-
-  x <- c("/",   "c:\\", "~/",  "foo", "http://rseek.org/", "'./'")
-  y <- c(FALSE, FALSE,  FALSE, FALSE, FALSE,               FALSE)
-  expect_identical(f(x), y)
-
-  x <- c("/foo", "foo/", "foo/bar", "foo//bar", "./foo", "../foo")
-  y <- c(FALSE,  TRUE,   TRUE,      TRUE,       TRUE,    TRUE)
-  expect_identical(f(x), y)
-
-  x <- c("\\\\", "\\foo", "foo\\", "foo\\bar", ".\\foo", "..\\foo", ".",  "..", "../")
-  y <- c(FALSE,  FALSE,   TRUE,    TRUE,       TRUE,     TRUE,      TRUE, TRUE, TRUE)
-  expect_identical(f(x), y)
-})
-
-
 test_that("is_path", {
   f <- lintr:::is_path
 

tests/testthat/test-lint_dir.R

@@ -20,7 +20,6 @@ test_that("lint all relevant directories in a package", {
     c("package.Rproj", "DESCRIPTION", "NAMESPACE", "lintr_test_config")
   )
 
-  lintr:::read_settings(NULL)
   lints <- lint_package(the_pkg, parse_settings = FALSE)
   linted_files <- unique(names(lints))
 
@@ -34,7 +33,6 @@ test_that("lint all relevant directories in a package", {
   # We want to ensure that object_name_linter uses namespace_imports correctly.
   # assignment_linter is needed to cause a lint in all vignettes.
   linters <- list(assignment_linter(), object_name_linter())
-  lintr:::read_settings(NULL)
   lints <- lint_package(the_pkg, linters = linters, parse_settings = FALSE)
   linted_files <- unique(names(lints))
 

tests/testthat/test-methods.R

@@ -1,21 +1,9 @@
-test_that("it returns the input if less than the max", {
-  expect_identical(lintr:::trim_output(character()), character())
-  expect_identical(lintr:::trim_output("test", max = 10L), "test")
-})
-
-test_that("it returns the input trimmed strictly to max if no lints found", {
-  expect_identical(lintr:::trim_output("testing a longer non_lint string", max = 7L), "testing")
-})
-
 test_that("it returns the input trimmed to the last full lint if one exists within the max", {
   t1 <- readChar(test_path("lints"), file.size(test_path("lints")))
   if (.Platform$OS.type == "windows") {
     # Magic numbers expect newlines to be 1 character
     t1 <- gsub("\r\n", "\n", t1, fixed = TRUE)
   }
-  expect_identical(lintr:::trim_output(t1, max = 200L), substr(t1, 1L, 195L))
-  expect_identical(lintr:::trim_output(t1, max = 400L), substr(t1, 1L, 380L))
-  expect_identical(lintr:::trim_output(t1, max = 2000L), substr(t1, 1L, 1930L))
 })
 
 test_that("as.data.frame.lints", {