Skip to content

consolidate root config for formatter-maven-plugin and impsort-maven-plugin #48372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Pankraz76
Copy link

it seems suitable to have only one root config now duplicated all over.

works on my machine:

image

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 13, 2025
Copy link

quarkus-bot bot commented Jun 13, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Pankraz76
Copy link
Author

one config seems to be enough instead of duplicating many times.

@Pankraz76 Pankraz76 marked this pull request as ready for review June 13, 2025 13:38
@Pankraz76
Copy link
Author

is having one config possible? @gastaldi

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense now that we have a common parent.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 13, 2025

This comment has been minimized.

@Pankraz76
Copy link
Author

thx.

@Pankraz76 Pankraz76 changed the title use root config of formatter-maven-plugin use root config for formatter-maven-plugin Jun 13, 2025
@Pankraz76
Copy link
Author

Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin net.revelc.code.formatter:formatter-maven-plugin:2.26.0 or one of its dependencies could not be resolved:
Could not find artifact io.quarkus:quarkus-ide-config:jar:999-SNAPSHOT

@Pankraz76 Pankraz76 force-pushed the centralize-plugin branch 2 times, most recently from d49cbe4 to 6184063 Compare June 13, 2025 20:08
@Pankraz76 Pankraz76 changed the title use root config for formatter-maven-plugin use root config for formatter-maven-plugin and impsort-maven-plugin Jun 14, 2025
@Pankraz76 Pankraz76 force-pushed the centralize-plugin branch from 6184063 to e43210f Compare June 14, 2025 09:17
@gsmet gsmet closed this Jun 14, 2025
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 14, 2025
@Pankraz76
Copy link
Author

Pankraz76 commented Jun 15, 2025

whats the reason for closing please?

I would like to improve Quarkus one commit at a time, as well.

https://www.goodreads.com/quotes/192325-it-is-not-enough-for-code-to-work

@Pankraz76
Copy link
Author

Cost of refactoring always outbalance, cost of carry.

@Pankraz76 Pankraz76 changed the title use root config for formatter-maven-plugin and impsort-maven-plugin consolidate root config for formatter-maven-plugin and impsort-maven-plugin Jun 18, 2025
@Pankraz76
Copy link
Author

Pankraz76 commented Jun 18, 2025

please consider reopen as seem to be valid increment.

this has do be done anyways when making next change, not to make it X times, but only once.

Like seen in:

@maxandersen
Copy link
Member

This PR was closed as part of a broader review of recent contributions.

We value efforts to improve consistency and tooling, but they need to create meaningful progress without adding unnecessary noise or maintenance overhead.

We appreciate the effort, but at this point, we’ve decided not to proceed with this specific PR.

For those considering similar contributions, we recommend starting with a focused issue, and if submitting a PR, ensure CI runs clean and avoid overloading maintainers with excessive volume of notifications. Clear communication and openness to feedback go a long way in making contributions successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants