-
Notifications
You must be signed in to change notification settings - Fork 2.9k
(re)activate maven.compiler.release
thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix UnnecessaryImport
#48414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
501b54f
to
f866089
Compare
spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix UnnecessaryImportmaven.compiler.release
property thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix UnnecessaryImport
...ts/tools/codestarts/src/test/java/io/quarkus/devtools/codestarts/core/CodestartDataTest.java
Show resolved
Hide resolved
f866089
to
0bc16b8
Compare
0bc16b8
to
91ed388
Compare
maven.compiler.release
property thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix UnnecessaryImport
maven.compiler.release
property thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix Unnecessary/WildcardImport
...oyment/src/test/java/io/quarkus/resteasy/reactive/jsonb/deployment/test/sse/SseResource.java
Show resolved
Hide resolved
91ed388
to
78cdabd
Compare
@@ -1,7 +1,6 @@ | |||
package io.quarkus.cache.redis.runtime; | |||
|
|||
import java.lang.reflect.Type; | |||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry dont want to bother and spam. this could really close the issue and i dont mean by ban me but ban the wildcard imports as now plugin has ability to do once.
maven.compiler.release
property thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix Unnecessary/WildcardImport
maven.compiler.release
thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix Unnecessary/WildcardImport
maven.compiler.release
thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix Unnecessary/WildcardImport
maven.compiler.release
thus consolidate spotless-maven-plugin
, impsort-maven-plugin
, and PMD
to fix UnnecessaryImport
246a71e
to
8cb424a
Compare
41cbcc1
to
09f08b6
Compare
…lugin, impsort-maven-plugin, and PMD to fix UnnecessaryImport
<configuration> | ||
<!-- store outside of target to speed up formatting when mvn clean is used --> | ||
<cachedir>.cache/impsort-maven-plugin-${version.impsort.plugin}</cachedir> | ||
<groups>java.,javax.,jakarta.,org.,com.</groups> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature envy.
09f08b6
to
d1f608f
Compare
quarkus dont care about (re)activate maven.compiler.release |
formatter-maven-plugin
andimpsort-maven-plugin
#48372spotless-maven-plugin
,formatter-maven-plugin
, andimpsort-maven-plugin
#48394@gsmet thanks for pull of format fix.
current setup has blindspots, like every tool, therefore using spot and PMD will reach the initial goal fixing implemented workarounds and flaws.
PMD:
Spot: