Skip to content

fix missing alphabetical order with sortpom-maven-plugin #48382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Jun 14, 2025

  <properties>
    <!-- Plugin versions (please keep in alphabetical order) -->
    <format.skip>false</format.skip>
    <insecure.repositories>ERROR</insecure.repositories>
    <jdk.min.version>${maven.compiler.argument.source}</jdk.min.version>
    <maven.compiler.argument.source>${maven.compiler.source}</maven.compiler.argument.source>
    <maven.compiler.argument.target>${maven.compiler.target}</maven.compiler.argument.target>
    <maven.compiler.argument.testSource>${maven.compiler.testSource}</maven.compiler.argument.testSource>
    <maven.compiler.argument.testTarget>${maven.compiler.testTarget}</maven.compiler.argument.testTarget>
    <maven.compiler.parameters>true</maven.compiler.parameters>
    <maven.compiler.release>17</maven.compiler.release>
    <maven.compiler.source>${maven.compiler.release}</maven.compiler.source>
    <maven.compiler.source>17</maven.compiler.source>
    <maven.compiler.target>${maven.compiler.release}</maven.compiler.target>
    <maven.compiler.target>17</maven.compiler.target>
    <maven.compiler.testSource>${maven.compiler.source}</maven.compiler.testSource>
    <maven.compiler.testTarget>${maven.compiler.target}</maven.compiler.testTarget>
    <maven.javadoc.failOnError>false</maven.javadoc.failOnError>
    <maven.min.version>3.9.6</maven.min.version>
    <project.build.outputTimestamp>2024-01-01T00:00:00Z</project.build.outputTimestamp>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
    <useReleaseProfile>false</useReleaseProfile>
    <version.archetype.plugin>3.4.0</version.archetype.plugin>
    <version.buildhelper.plugin>3.6.1</version.buildhelper.plugin>
    <version.buildnumber.plugin>3.2.1</version.buildnumber.plugin>
    <version.clean.plugin>3.5.0</version.clean.plugin>
    <version.compiler.plugin>3.14.0</version.compiler.plugin>
    <version.dependency.plugin>3.8.1</version.dependency.plugin>
    <version.deploy.plugin>3.1.4</version.deploy.plugin>
    <version.enforcer.plugin>3.5.0</version.enforcer.plugin>
    <version.exec.plugin>3.5.1</version.exec.plugin>
    <version.failsafe.plugin>${version.surefire.plugin}</version.failsafe.plugin>
    <version.forbiddenapis-maven-plugin>3.4</version.forbiddenapis-maven-plugin>
    <version.formatter.plugin>2.26.0</version.formatter.plugin>
    <version.gpg.plugin>3.2.7</version.gpg.plugin>
    <version.impsort.plugin>1.12.0</version.impsort.plugin>
    <version.install.plugin>3.1.4</version.install.plugin>
    <version.jar.plugin>3.4.2</version.jar.plugin>
    <version.javadoc.plugin>3.11.2</version.javadoc.plugin>
    <version.plugin.plugin>3.15.1</version.plugin.plugin>
    <version.release.plugin>3.1.1</version.release.plugin>
    <version.resources.plugin>3.3.1</version.resources.plugin>
    <!-- Do not update for now as it is causing test issues in integration-tests/devmode
        java.lang.NoClassDefFoundError: com/salesforce/jprotoc/Generator -->
    <version.shade.plugin>3.2.1</version.shade.plugin>
    <version.source.plugin>3.3.1</version.source.plugin>
    <version.surefire.plugin>3.5.3</version.surefire.plugin>
    <version.versions.plugin>2.18.0</version.versions.plugin>
    <version.yaml-properties.plugin>1.1.3</version.yaml-properties.plugin>
  </properties>
Image Image

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/codestarts area/context-propagation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-validator Hibernate Validator area/platform Issues related to definition and interaction with Quarkus Platform area/smallrye area/testing area/vertx labels Jun 14, 2025
Copy link

quarkus-bot bot commented Jun 14, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Pankraz76 Pankraz76 changed the title handle property order: please keep in alphabetical order fix missing alphabetical order with sortpom-maven-plugin Jun 14, 2025
<build>
<resources>
<resource>
<directory>${project.build.sourceDirectory}</directory>
Copy link
Author

@Pankraz76 Pankraz76 Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questionable order.

@Pankraz76
Copy link
Author

reopen when order is fixed.

@gsmet
Copy link
Member

gsmet commented Jun 14, 2025

@Pankraz76 I will repeat myself again but if you want to contribute, please focus on actual issues.

It's not possible for us to handle the constant stream of PRs you open.

So please focus on issues, or we will be forced to close the PRs you open.

@Pankraz76
Copy link
Author

I can not really contribute to bugs, as im not aware of the software in detail. My motivation is to increment on existing flaws that are easy to pick.

Like the centralization of redundant config like seen in:

It was approved twice, assuming its an increment. Closing it then without any feedback seems questionable as the effort spend seems lost.

Having a solid codebase comes with benefits for the whole dev community.

PS:

Did not get this message directly. Consider unblock then i might get notifications again.

@Pankraz76
Copy link
Author

I do what I can, currently its only housekeeping as this is a generic thing.

I dont want to spam you and take away capacity, so we need to align before doing so.

Im very proactive trying to speak with pictures(PR´s). I learn and improve every time by doing, so even when you close for good reason i will make profit.

Lets try to make profit for Quakus as well.

You have no time to fix dept, we all know the game. So why not let people do it in their free time. Everybody will benefit from fixing flaws.

Cost of refactoring always outbalance cost of carry.

@Pankraz76
Copy link
Author

just consider 2/3 of quarkus code is obsolete regarding error handling:

Yes, some can argue its not an actual issue.

Having small and update code is not a bad think.

https://www.goodreads.com/quotes/192325-it-is-not-enough-for-code-to-work

@Pankraz76
Copy link
Author

is this one a real issue worth enough ?

@gsmet

if then consider 3 for 1 tradeoff use spot to fix imports format and format overall in once.

issue:

fix:

@Pankraz76
Copy link
Author

should it be same version?

image

@maxandersen
Copy link
Member

@Pankraz76 Thanks for your ongoing contributions — we really do appreciate the time and effort you’re putting into improving the codebase.

That said, please keep in mind that even seemingly simple “cleanup” changes aren’t free. Changes made solely to satisfy a linter or stylistic preference can introduce unintended consequences — especially when we need to backport fixes or maintain long-term stability. Every change, no matter how minor, requires review, testing, and potentially complicates the history for future maintainers.

In that context, we’d prefer contributions that address actual bugs, performance issues, or meaningful improvements. Cleaning up code that already works fine, while well-intentioned, can sometimes do more harm than good.

We want to encourage contributions that make a real impact — so if you’re looking for areas to help with, we’d be happy to point you toward things that could really use attention.
.

@Pankraz76
Copy link
Author

agree up, really appreciate.

the risk is unknown and nothing comes for free.

@Pankraz76
Copy link
Author

really use attention

like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/cache area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/config area/context-propagation area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/elasticsearch area/fault-tolerance area/flyway area/funqy area/google-cloud-functions area/gradle Gradle area/graphics area/graphql area/grpc gRPC area/health area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/hibernate-search Hibernate Search area/hibernate-validator Hibernate Validator area/infinispan Infinispan area/jackson Issues related to Jackson (JSON library) area/jaxb area/jdbc Issues related to the JDBC extensions area/kafka area/kafka-streams area/keycloak area/kotlin area/kubernetes area/liquibase area/logging area/lra area/mailer area/maven area/metrics area/mongodb area/mutiny area/narayana Transactions / Narayana area/netty area/oidc area/openapi area/panache area/picocli area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/reactive-messaging area/reactive-sql-clients area/reactive-streams-operators area/redis area/rest area/rest-client area/resteasy-classic area/scala area/scheduler area/security area/smallrye area/spring Issues relating to the Spring integration area/stork area/swagger-ui area/testing area/tracing area/undertow area/vertx area/websockets triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants