-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix missing alphabetical order with sortpom-maven-plugin
#48382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
sortpom-maven-plugin
<build> | ||
<resources> | ||
<resource> | ||
<directory>${project.build.sourceDirectory}</directory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here why no alphabetical order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questionable order.
reopen when order is fixed. |
@Pankraz76 I will repeat myself again but if you want to contribute, please focus on actual issues. It's not possible for us to handle the constant stream of PRs you open. So please focus on issues, or we will be forced to close the PRs you open. |
I can not really contribute to bugs, as im not aware of the software in detail. My motivation is to increment on existing flaws that are easy to pick. Like the centralization of redundant config like seen in: It was approved twice, assuming its an increment. Closing it then without any feedback seems questionable as the effort spend seems lost. Having a solid codebase comes with benefits for the whole dev community. PS: Did not get this message directly. Consider unblock then i might get notifications again. |
I do what I can, currently its only housekeeping as this is a generic thing. I dont want to spam you and take away capacity, so we need to align before doing so. Im very proactive trying to speak with pictures(PR´s). I learn and improve every time by doing, so even when you close for good reason i will make profit. Lets try to make profit for Quakus as well. You have no time to fix dept, we all know the game. So why not let people do it in their free time. Everybody will benefit from fixing flaws. Cost of refactoring always outbalance cost of carry. |
just consider 2/3 of quarkus code is obsolete regarding error handling: Yes, some can argue its not an actual issue. Having small and update code is not a bad think. https://www.goodreads.com/quotes/192325-it-is-not-enough-for-code-to-work |
is this one a real issue worth enough ? if then consider 3 for 1 tradeoff use spot to fix imports format and format overall in once. issue:
fix: |
@Pankraz76 Thanks for your ongoing contributions — we really do appreciate the time and effort you’re putting into improving the codebase. That said, please keep in mind that even seemingly simple “cleanup” changes aren’t free. Changes made solely to satisfy a linter or stylistic preference can introduce unintended consequences — especially when we need to backport fixes or maintain long-term stability. Every change, no matter how minor, requires review, testing, and potentially complicates the history for future maintainers. In that context, we’d prefer contributions that address actual bugs, performance issues, or meaningful improvements. Cleaning up code that already works fine, while well-intentioned, can sometimes do more harm than good. We want to encourage contributions that make a real impact — so if you’re looking for areas to help with, we’d be happy to point you toward things that could really use attention. |
agree up, really appreciate. the risk is unknown and nothing comes for free. |
like this? |
quarkus/independent-projects/parent/pom.xml
Line 19 in cfe7a05