Skip to content

Support export program in intermediate numeric discrepancy detector #12581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 29, 2025

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jul 17, 2025

Stack from ghstack (oldest at bottom):

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: D78298935

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12581

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit 05a6000 with merge base 45846c8 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2025
Gasoonjia added a commit that referenced this pull request Jul 17, 2025
This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

ghstack-source-id: 296761254
Pull Request resolved: #12581
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

Copy link
Contributor

@Juntian777 Juntian777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 17, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 296905461
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 18, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 297184685
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 18, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 297184685
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 18, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 297210901
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 24, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 298366521
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 24, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 298435731
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 25, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 298666564
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

@Gasoonjia Gasoonjia added the release notes: none Do not include this in the release notes label Jul 25, 2025
… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 28, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 299039096
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

… detector"

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jul 28, 2025
Pull Request resolved: #12581

This diff enables intermediate numeric discrepancy detector to leverage export program as label.

More specific, if user creates etrecord with exported program, and the exported program is one of the exported programs in the export flow, then our numeric discrepancy detector will use it as label. Otherwise, we will continue use edge dialect graph as label.
ghstack-source-id: 299040326
@exported-using-ghexport

Differential Revision: [D78298935](https://our.internmc.facebook.com/intern/diff/D78298935/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78298935

@facebook-github-bot facebook-github-bot merged commit e519dff into gh/gasoonjia/27/base Jul 29, 2025
95 of 101 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/gasoonjia/27/head branch July 29, 2025 02:28
Gasoonjia added a commit that referenced this pull request Jul 29, 2025
…12944)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #12581 by
@Gasoonjia
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/27/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/27/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/26/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/27/orig
@diff-train-skip-merge

---------

Co-authored-by: gasoonjia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants