make operator name consistent before and after serde #12531
+41
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12531
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New FailuresAs of commit fc94bf2 with merge base 0012ffa ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Gasoonjia
added a commit
that referenced
this pull request
Jul 15, 2025
Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/) ghstack-source-id: 296452087 Pull Request resolved: #12531
|
This pull request was exported from Phabricator. Differential Revision: D78380855 |
This PR needs a
|
Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Jul 15, 2025
Pull Request resolved: #12531 Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/) ghstack-source-id: 296453986
|
This pull request was exported from Phabricator. Differential Revision: D78380855 |
angelayi
approved these changes
Jul 16, 2025
Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Jul 16, 2025
Pull Request resolved: #12531 Node name consistency is important for et because we need to trace the node flow by using node name + graph id + from_node info in the deserialized graph in inspector. Currently we can not have a consistency experience because we didn't record node name as part of schema, but instead, leverging the output info, which didn't record the node name for multiple output node. This diff makes node name as part of schema to ensure the consistency. Also create tests for coverage. ghstack-source-id: 296600899 Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/)
|
This pull request was exported from Phabricator. Differential Revision: D78380855 |
Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Jul 16, 2025
Pull Request resolved: #12531 Node name consistency is important for et because we need to trace the node flow by using node name + graph id + from_node info in the deserialized graph in inspector. Currently we can not have a consistency experience because we didn't record node name as part of schema, but instead, leverging the output info, which didn't record the node name for multiple output node. This diff makes node name as part of schema to ensure the consistency. Also create tests for coverage. ghstack-source-id: 296611329 Differential Revision: [D78380855](https://our.internmc.facebook.com/intern/diff/D78380855/)
|
This pull request was exported from Phabricator. Differential Revision: D78380855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D78380855