Skip to content

Serializing from_node info in et serializer #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: gh/gasoonjia/23/base
Choose a base branch
from
Open

Serializing from_node info in et serializer #12462

wants to merge 5 commits into from

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jul 14, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector. this diff updates the serizalier to support serde from_node info.

Differential Revision: D78293986

@Gasoonjia
Serializing from_node info in et serializer
bc669bc 
We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector.  this diff updates the serizalier to support serde from_node info.

Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)

[ghstack-poisoned]
@Gasoonjia Gasoonjia mentioned this pull request Jul 14, 2025
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12462

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 915f3a3 with merge base 0012ffa (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Gasoonjia Gasoonjia mentioned this pull request Jul 14, 2025
Closed
Gasoonjia added a commit that referenced this pull request Jul 14, 2025
@Gasoonjia
Serializing from_node info in et serializer
2aa0406 
We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector.  this diff updates the serizalier to support serde from_node info.

Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)

ghstack-source-id: 296149500
Pull Request resolved: #12462
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78293986

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia
Update on "Serializing from_node info in et serializer"
8a0e1f7 
We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector.  this diff updates the serizalier to support serde from_node info.

Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)

[ghstack-poisoned]
@Gasoonjia Gasoonjia mentioned this pull request Jul 15, 2025
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78293986

@Gasoonjia
Update on "Serializing from_node info in et serializer"
35b69bf 
We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector.  this diff updates the serizalier to support serde from_node info.

Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78293986

@Gasoonjia
Update on "Serializing from_node info in et serializer"
53a8b57 
We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector.  this diff updates the serizalier to support serde from_node info.

Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)

[ghstack-poisoned]
@Gasoonjia Gasoonjia mentioned this pull request Jul 16, 2025
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78293986

@Gasoonjia
Update on "Serializing from_node info in et serializer"
915f3a3 
We need to use the from_node informaton in deserialzied exported graph for operator tracing in et.inspector.  this diff updates the serizalier to support serde from_node info.

Differential Revision: [D78293986](https://our.internmc.facebook.com/intern/diff/D78293986/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78293986

This was referenced Jul 17, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gasoonjia @facebook-github-bot @angelayi