Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write the Silence wiki page #12505

Merged
merged 10 commits into from
Dec 15, 2024
Merged

Re-write the Silence wiki page #12505

merged 10 commits into from
Dec 15, 2024

Conversation

0x84f
Copy link
Contributor

@0x84f 0x84f commented Dec 1, 2024

in its current state this is a proposed re-write of the Silence page by Nathanael, changes will be made along the way as the team decides what can stay, what should go, and what needs to be added

Related internal discussion
preview

Copy link

Someone else has edited same files as you did. Please check their changes in case they conflict with yours:

wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Userlog2 Userlog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good PR, but had some ideas about improving wording, making things more consistent with #12441, and fixing grammar.

why is everything on the wrong line help

wiki/Silence/en.md Show resolved Hide resolved
Copy link
Contributor

@Userlog2 Userlog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be broken this time

wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Silence/en.md Outdated Show resolved Hide resolved
@Walavouchey Walavouchey merged commit 99edb6a into ppy:master Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants