Allow for a candidate to have a Closure as a class parameter #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2016
Merged
|
squash and merge? |
|
I rebased the PR and added FYI. I do not want the ClassDiscovery to instantiate the class because the |
|
thanks! |
|
Thank you for merging. |
| /** | ||
| * Get an instance of the $class. | ||
| * | ||
| * @param string|\Closure $class A FQN of a class or a closure that instantiate the class. |
|
Added a few comments. Nice work. 👍 |
Nyholm
added a commit
to Nyholm/discovery
that referenced
this pull request
Jul 7, 2016
dbu
pushed a commit
that referenced
this pull request
Jul 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow you to return a closure as a class parameter on the candidate. The good thing about this is that someone can write their own strategy that emulates a async client. An example of such strategy is seen in #65.
This will increase the extendibility in the discovery mechanism.