POC how an emulated async strategy may look like #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really like this. It adds an optional dependency. And IMO this is not how resources should be resolved. Also, this is not much code: I would just have something similar in the docs or cookbook. |
|
Sorry if I wasn't clear. The EmulateAsyncClientStrategy does not belong in this repo for the reason you mention. But if we should allow a class similar to EmulateAsyncClientStrategy in the cookbook we have to make the changes in the ClassDiscovery and the the other *Discovery classes. I just want your feedback/opinions/suggestions for the changes in the ClassDiscovery and the *Discovery classes. See #57 (comment) |
| @@ -36,7 +36,7 @@ | |||
| * | |||
| * @param string $type | |||
| * | |||
| * @return string | |||
| * @return string|\Closure | |||
There was a problem hiding this comment.
Do we want to allow this function to return a Closure?
|
Im closing this PR in favor for #66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged. I just want to show how I, as an application author, may force discovery to emulate an async client.
Ref: #57