Base exception #67
Merged
Base exception #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be happier with a marker interface. |
|
But you cant catch an interface, right? Or can you? If so, an interface is way better. try {
$client = HttpClientDiscovery::find()
} catch(DiscoveryExceptionInterface $e) {
// log
} |
|
Of course you can. As long as the implementation extends |
|
Cool, thank you. I've updated the PR. |
| namespace Http\Discovery; | ||
|
|
||
| /** | ||
| * An interface implemented by all our exception. |
|
Can you please add a changelog entry too? (You might need to rebase your branch though, I added change logs in the master as well) |
|
PR updated. |
| namespace Http\Discovery; | ||
|
|
||
| /** | ||
| * An interface implemented by all our exceptions. |
There was a problem hiding this comment.
s/by all our/by all discovery related/
Nyholm
force-pushed
the
exception
branch
2 times, most recently
from
dfc0056 to
400e1a5
Compare
|
Rebased and squashed. |
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing #66 made me think of introducing a base exception that all our exception extends from. This will make it easier to catch a discovery exception in case something goes wrong.
This will be extra relevant if #66 gets merged because it introduces another exception.