-
Notifications
You must be signed in to change notification settings - Fork 46
Base exception #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Base exception #67
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<?php | ||
|
||
namespace Http\Discovery; | ||
|
||
/** | ||
* An interface implemented by all discovery related exceptions. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
*/ | ||
interface Exception | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,14 @@ | |
|
||
namespace Http\Discovery\Exception; | ||
|
||
use Http\Discovery\Exception; | ||
|
||
/** | ||
* Thrown when all discovery strategies fails to find a resource. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
*/ | ||
final class DiscoveryFailedException extends \Exception | ||
final class DiscoveryFailedException extends \Exception implements Exception | ||
{ | ||
/** | ||
* @var array | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,13 +2,15 @@ | |
|
||
namespace Http\Discovery\Exception; | ||
|
||
use Http\Discovery\Exception; | ||
|
||
/** | ||
* Thrown when a discovery does not find any matches. | ||
* | ||
* @final do NOT extend this class, not final for BC reasons | ||
* | ||
* @author Márk Sági-Kazár <[email protected]> | ||
*/ | ||
/*final */class NotFoundException extends \RuntimeException | ||
/*final */class NotFoundException extends \RuntimeException implements Exception | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,14 @@ | |
|
||
namespace Http\Discovery\Exception; | ||
|
||
use Http\Discovery\Exception; | ||
|
||
/** | ||
* This exception is thrown when we cannot use a discovery strategy. This is *not* thrown when | ||
* the discovery fails to find a class. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
*/ | ||
class StrategyUnavailableException extends \RuntimeException | ||
class StrategyUnavailableException extends \RuntimeException implements Exception | ||
{ | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the interface itself not live in the exception namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the example in HTTPlug: https://github.com/php-http/httplug/tree/master/src
I did some (very little) research and it seams that (a few) others are doing the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception\Exception sounds weird, also, the inheritance is also reflected in the naming this way, which seems to be logical to me.