[release-4.20] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest #559

openshift-cherrypick-robot · 2025-09-19T12:54:09Z

This is an automated cherry-pick of #551

/assign flavianmissi

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

coderabbitai · 2025-09-19T12:54:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-09-19T12:54:20Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37215 has been cloned as Jira Issue OCPBUGS-61982. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest

Details

In response to this:

This is an automated cherry-pick of #551

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-19T12:54:35Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61982, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #551

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

davegord · 2025-11-13T19:40:40Z

/jira refresh

openshift-ci-robot · 2025-11-13T19:40:44Z

@davegord: This pull request references Jira Issue OCPBUGS-61982, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

davegord · 2025-11-13T19:43:30Z

/jira refresh

openshift-ci-robot · 2025-11-13T19:43:39Z

@davegord: This pull request references Jira Issue OCPBUGS-61982, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-37215 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-37215 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricardomaraschini · 2025-11-20T09:01:42Z

/approved

ricardomaraschini · 2025-11-20T09:03:18Z

/approve

ricardomaraschini · 2025-11-20T09:58:35Z

/approve

ricardomaraschini · 2025-11-20T10:06:53Z

/lgtm

openshift-ci · 2025-11-20T10:07:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/image/OWNERS~~ [ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ricardomaraschini · 2025-11-20T10:09:08Z

/label backport-risk-assessed

openshift-ci · 2025-11-20T10:09:37Z

@ricardomaraschini: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ingvagabund · 2025-11-20T10:26:21Z

/label backport-risk-assessed

xiuwang · 2025-11-21T09:41:22Z

/verified by @xiuwang

openshift-ci-robot · 2025-11-21T09:41:50Z

@xiuwang: This PR has been marked as verified by @xiuwang.

Details

In response to this:

/verified by @xiuwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-21T11:59:19Z

/retest-required

Remaining retests: 0 against base HEAD 1a249ce and 2 for PR HEAD 71bc974 in total

ricardomaraschini · 2025-11-24T11:29:34Z

/retest-required

ricardomaraschini · 2025-11-24T14:26:07Z

/retest-required

ricardomaraschini · 2025-11-24T15:18:08Z

/retest-required

openshift-ci · 2025-11-24T18:16:48Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-11-24T18:21:07Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-61982
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61982 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #551

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricardomaraschini · 2025-11-25T10:11:10Z

/cherrypick release-4.19

openshift-cherrypick-robot · 2025-11-25T10:11:53Z

@ricardomaraschini: new pull request created: #582

Details

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-11-26T06:49:53Z

Fix included in accepted release 4.20.0-0.nightly-2025-11-26-003240

flavianmissi added 2 commits September 19, 2025 12:54

pkg/image: conditionally parse raw image manifest

d5c227e

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

pkg/image: pre-allocate subManifests slice

71bc974

openshift-cherrypick-robot assigned flavianmissi Sep 19, 2025

openshift-cherrypick-robot mentioned this pull request Sep 19, 2025

OCPBUGS-37215: pkg/image: conditionally parse raw image manifest #551

Merged

openshift-ci bot changed the title ~~[release-4.20] OCPBUGS-37215: pkg/image: conditionally parse raw image manifest~~ [release-4.20] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest Sep 19, 2025

openshift-ci bot requested review from adambkaplan and flavianmissi September 19, 2025 12:54

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 13, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025

openshift-ci bot assigned ricardomaraschini Nov 20, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 20, 2025

openshift-ci bot assigned gangwgr, wangke19 and xingxingxia Nov 20, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 21, 2025

openshift-merge-bot bot merged commit 1cb668d into openshift:release-4.20 Nov 24, 2025
13 checks passed

openshift-cherrypick-robot mentioned this pull request Nov 25, 2025

[release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest #582

Merged

[release-4.20] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest #559

[release-4.20] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest #559

Uh oh!

Conversation

openshift-cherrypick-robot commented Sep 19, 2025

Uh oh!

coderabbitai bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

davegord commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

davegord commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

ricardomaraschini commented Nov 20, 2025

Uh oh!

ricardomaraschini commented Nov 20, 2025

Uh oh!

ricardomaraschini commented Nov 20, 2025

Uh oh!

ricardomaraschini commented Nov 20, 2025

Uh oh!

openshift-ci bot commented Nov 20, 2025

Uh oh!

ricardomaraschini commented Nov 20, 2025

Uh oh!

openshift-ci bot commented Nov 20, 2025

Uh oh!

ingvagabund commented Nov 20, 2025

Uh oh!

xiuwang commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

openshift-ci-robot commented Nov 21, 2025

Uh oh!

ricardomaraschini commented Nov 24, 2025

Uh oh!

ricardomaraschini commented Nov 24, 2025

Uh oh!

ricardomaraschini commented Nov 24, 2025

Uh oh!

openshift-ci bot commented Nov 24, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

ricardomaraschini commented Nov 25, 2025

Uh oh!

openshift-cherrypick-robot commented Nov 25, 2025

Uh oh!

openshift-merge-robot commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

coderabbitai bot commented Sep 19, 2025 •

edited

Loading