[release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest #582

openshift-cherrypick-robot · 2025-11-25T10:11:51Z

This is an automated cherry-pick of #559

/assign ricardomaraschini

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

openshift-ci-robot · 2025-11-25T10:12:01Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-61982 has been cloned as Jira Issue OCPBUGS-65962. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest

Details

In response to this:

This is an automated cherry-pick of #559

/assign ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-11-25T10:12:08Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-11-25T10:12:14Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-65962, which is invalid:

expected dependent Jira Issue OCPBUGS-61982 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #559

/assign ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricardomaraschini · 2025-11-25T14:41:03Z

/approve
/lgtm

openshift-ci · 2025-11-25T14:41:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/image/OWNERS~~ [ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ricardomaraschini · 2025-12-01T10:50:49Z

/jira refresh

openshift-ci-robot · 2025-12-01T10:50:57Z

@ricardomaraschini: This pull request references Jira Issue OCPBUGS-65962, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-61982 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-61982 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ingvagabund · 2025-12-01T10:52:47Z

/label backport-risk-assessed

ricardomaraschini · 2025-12-01T10:53:18Z

/cherrypick release-4.18

openshift-cherrypick-robot · 2025-12-01T10:53:21Z

@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xiuwang · 2025-12-04T02:50:59Z

/verified by @xiuwang

openshift-ci-robot · 2025-12-04T02:51:10Z

@xiuwang: This PR has been marked as verified by @xiuwang.

Details

In response to this:

/verified by @xiuwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-04T05:26:53Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-12-04T05:30:48Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-65962
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65962 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #559

/assign ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-12-04T05:31:42Z

@ricardomaraschini: new pull request created: #585

Details

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

flavianmissi added 2 commits November 25, 2025 10:11

pkg/image: conditionally parse raw image manifest

6953340

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

pkg/image: pre-allocate subManifests slice

e5b8672

openshift-cherrypick-robot assigned ricardomaraschini Nov 25, 2025

openshift-cherrypick-robot mentioned this pull request Nov 25, 2025

[release-4.20] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest #559

Merged

openshift-ci bot changed the title ~~[release-4.19] OCPBUGS-61982: pkg/image: conditionally parse raw image manifest~~ [release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest Nov 25, 2025

openshift-ci bot requested review from QiWang19 and ricardomaraschini November 25, 2025 10:12

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 1, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 1, 2025

openshift-ci bot assigned gangwgr, wangke19 and xingxingxia Dec 1, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 4, 2025

openshift-merge-bot bot merged commit 8a912a1 into openshift:release-4.19 Dec 4, 2025
11 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 4, 2025

[release-4.18] OCPBUGS-66379: pkg/image: conditionally parse raw image manifest #585

Open

[release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest #582

[release-4.19] OCPBUGS-65962: pkg/image: conditionally parse raw image manifest #582

Uh oh!

Conversation

openshift-cherrypick-robot commented Nov 25, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

coderabbitai bot commented Nov 25, 2025

Review skipped

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

ricardomaraschini commented Nov 25, 2025

Uh oh!

openshift-ci bot commented Nov 25, 2025

Uh oh!

ricardomaraschini commented Dec 1, 2025

Uh oh!

openshift-ci-robot commented Dec 1, 2025

Uh oh!

ingvagabund commented Dec 1, 2025

Uh oh!

ricardomaraschini commented Dec 1, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2025

Uh oh!

xiuwang commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants