OCPBUGS-37215: pkg/image: conditionally parse raw image manifest

[flavianmissi]

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

The diff doesn't make it so obvious, but the only change in this PR is to wrap manifest json parsing and submanifest creation into a condition that checks if the raw manifest is present.

/assign @ricardomaraschini

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-37215, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

The diff doesn't make it so obvious, but the only change in this PR is to wrap manifest json parsing and submanifest creation into a condition that checks if the raw manifest is present.

/assign @ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds a conditional guard in PrepareForCreate to only parse DockerImageManifest when present; moves UnmarshalManifest inside the guard, preserves error handling, and when a manifest list is detected, builds and assigns DockerImageManifests with extracted metadata. Adds comments clarifying two contexts and limits manifest-related variable scope.

Changes

Cohort / File(s)	Summary
Image manifest processing guard and metadata extraction pkg/image/apiserver/registry/image/strategy.go	- Skip manifest parsing when DockerImageManifest is empty in PrepareForCreate - Move UnmarshalManifest inside guard with existing error handling - On manifest list, construct and assign DockerImageManifests (Digest, MediaType, ManifestSize, Architecture, OS, Variant) - Add contextual comments (image stream import vs direct push) and tighten variable scope

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	Title clearly summarizes the primary change by indicating that the pkg/image logic now conditionally parses the raw image manifest, matching the pull request’s focus without unnecessary detail.
Description Check	✅ Passed	Description accurately explains the rationale and specific conditional change applied to manifest parsing, making it directly related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 11edcfa and f30057f.

📒 Files selected for processing (1)

• pkg/image/apiserver/registry/image/strategy.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/image/apiserver/registry/image/strategy.go

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e817f84 and 4f25a81.

📒 Files selected for processing (1)

• pkg/image/apiserver/registry/image/strategy.go (1 hunks)

[flavianmissi]

test failure is unrelated
/retest

[openshift-ci]

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ricardomaraschini]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/image/OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xiuwang]

/verified by @xiuwang

[xiuwang]

/label qe-approved

[openshift-ci-robot]

@xiuwang: This PR has been marked as verified by @xiuwang.

Details

In response to this:

/verified by @xiuwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@flavianmissi: This pull request references Jira Issue OCPBUGS-37215, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

The diff doesn't make it so obvious, but the only change in this PR is to wrap manifest json parsing and submanifest creation into a condition that checks if the raw manifest is present.

/assign @ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@flavianmissi: Jira Issue Verification Checks: Jira Issue OCPBUGS-37215
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-37215 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

the Image REST strategy logs errors when it cannot parse the raw json manifest when creating an Image object. however, this is not an error, as a call to this api might have already cleared the DockerImageManifest from the Image object.

The diff doesn't make it so obvious, but the only change in this PR is to wrap manifest json parsing and submanifest creation into a condition that checks if the raw manifest is present.

/assign @ricardomaraschini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@flavianmissi: new pull request created: #559

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in accepted release 4.21.0-0.nightly-2025-09-13-162334