chore: add max faraday version to tests #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faraday 2.0, to be removed once koala itself fixes versioning
ericmustin
requested review from
ahayworth,
arielvalentin,
dazuma,
fbogsany,
mwear and
robertlaurin
as code owners
|
cc @SomalianIvan this should unblock #1043 |
SomalianIvan
approved these changes
Jan 4, 2022
|
Sending my grey approval |
| @@ -13,6 +13,7 @@ gem 'opentelemetry-instrumentation-base', path: '../base' | |||
|
|
|||
| group :test do | |||
| gem 'byebug' | |||
| gem 'faraday', '<2.0' | |||
There was a problem hiding this comment.
Would this make more sense to be included in the appraisals file instead?
That would be true for cases where older versions of faraday would be compatible only with older versions of the koala gem no?
There was a problem hiding this comment.
hm, yea that probably makes more sense. practically speaking i think that the outcome of this issue comment arsduo/koala#659 (comment) will probably resolve this for us in general, but can move into appraisal for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temp workaround for arsduo/koala#659 to unblock CI until upstream Koala itself supports Faraday 2.0