Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add max faraday version to tests #1070

Merged
merged 1 commit into from
Jan 4, 2022
Merged

chore: add max faraday version to tests #1070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instrumentation/koala/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ gem 'opentelemetry-instrumentation-base', path: '../base'

group :test do
gem 'byebug'
gem 'faraday', '<2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this make more sense to be included in the appraisals file instead?

That would be true for cases where older versions of faraday would be compatible only with older versions of the koala gem no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, yea that probably makes more sense. practically speaking i think that the outcome of this issue comment arsduo/koala#659 (comment) will probably resolve this for us in general, but can move into appraisal for now.

gem 'opentelemetry-common', path: '../../common'
gem 'opentelemetry-sdk', path: '../../sdk'
gem 'opentelemetry-semantic_conventions', path: '../../semantic_conventions'
Expand Down